Cannot reproduce Upgrade script doesn't list all incompatible add-ons at once

[Jake B.]

Affected version

2.0.0 Beta 2

Tried running the upgrade, and got this:




So I reverted the files back to the xf1 files, removed that add-on, tried again and got this:

 

[Mike]

I don't see any reason for this -- the code does check all of them before returning a result. Not only that, the widget framework check happens before the multi prefix check, so if anything, you should've gotten that one first.

 

[Jake B.]

I don't see any reason for this -- the code does check all of them before returning a result. Not only that, the widget framework check happens before the multi prefix check, so if anything, you should've gotten that one first.

I might've take/posted the screenshots in the wrong order because I did leave the tab open and reopen the process in a separate tab and then took the screen shots after I went back for both, but it definitely happened for some reason. Will try the upgrade again later to see if I can reproduce it again

 

[Chris D]

I mean, the code is pretty clear:

<?php } else if ($addOnConflicts) { ?>
   <div class="blockMessage blockMessage--error">
      Conflicts with the following third-party add-ons have been detected:
      <ul>
         <?php foreach ($addOnConflicts AS $conflict) { ?>
            <li><?php echo $conflict; ?></li>
         <?php } ?>
      </ul>
      Upgrading XenForo is not possible until these conflicts have been resolved. Resolving these errors will generally
      require you to restore the XenForo files from your previous version and uninstall the conflicting add-on or upgrade
      it to a non-conflicting version. The add-on author may have more specific advice as to the steps you can take.
   </div>
<?php } else { ?>

That's expecting an array of conflicts and it lists each one.

Then if you look at XF\Install\Upgrader::getAddOnConflicts() you can see it should be populating the array completely for all conflicts.