Fixed Unused parameter on reaction

Affected version
2.1.6 Patch 1

kick

Well-known member
On save in admincp reaction, create a phrase for reaction title.
$masterTitle = $reaction->getMasterPhrase(true);
If we look at the entity of the reaction, we will see the missing applicable parameters
PHP:
public function getMasterPhrase()
{
   $phrase = $this->MasterTitle;
   if (!$phrase)
   {
      $phrase = $this->_em->create('XF:Phrase');
      $phrase->title = $this->_getDeferredValue(function() { return $this->getPhraseName(); }, 'save');
      $phrase->addon_id = '';
      $phrase->language_id = 0;
   }

   return $phrase;
}
 

XF Bug Bot

XenForo bug fixer bot
Staff member
Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.1.7).

Change log:
Remove unused parameter when fetching reaction phrase
There may be a delay before changes are rolled out to the XenForo Community.
 
Top