Fixed Unset in finalizeRebuildSet()

[digitalpoint]

Is the finalizeRebuildSet() method supposed to unset the entire $this->_bulkInserts property on every loop?

	public function finalizeRebuildSet()
	{
		foreach ($this->_bulkInserts AS $contentType => $results)
		{
			$result = XenES_Api::indexBulk($this->_indexName, $contentType, $this->_bulkInserts[$contentType]);
			$this->_assertIndexSuccessful($result, $contentType);
			unset($this->_bulkInserts);
		}
		$this->_bulkInserts = array();
	}

Maybe it's supposed to be unsetting the array it's working on?

It ends up with a fatal error if you are bulk rebuilding multiple content types... This works:

	public function finalizeRebuildSet()
	{
		foreach ($this->_bulkInserts AS $contentType => $results)
		{
			$result = XenES_Api::indexBulk($this->_indexName, $contentType, $this->_bulkInserts[$contentType]);
			$this->_assertIndexSuccessful($result, $contentType);
			unset($this->_bulkInserts[$contentType]);
		}
		$this->_bulkInserts = array();
	}

 

[Mike]

Good catch. Fixed for the next ES release.

 

[Hornstar]

Question: What does ES stand for?

 

[MattW]

Question: What does ES stand for?

Enhanced Search

 

[Andrej]

Question: What does ES stand for?

 

[Hornstar]

View attachment 51115

I got here from my news feed and didn't realize I was in this section. I thought it must have been some kind of beta or RC kind of term lol. It seems so obvious now lol.