Not a bug Unnecessary empty() function call in BbCode Base.php

[thedude]

Not so much a bug, but just a code cleanup issue.

In library/XenForo/BbCode/Formatter/Base.php, line 1054

$noFollow = (empty($rendererStates['noFollowDefault']) ? '' : ' rel="nofollow"');

$rendererStates['noFollowDefault'] is either true/false, so the empty() function surrounding is not needed

 

[cclaerhout]

The function empty() check if the given variable is true or false but is also used like an isset(). If the key noFollowDefault is not set, this will prevent a php error.

 

[Mike]

Yes, empty is perfectly valid even when it exists and basically the same as !isset($x) OR !$x.