Fixed Undefined variable $source in \library\XenForo\BbCode\Formatter\Base.php

[Yoskaldyr]

Please consider of adding one line of code into file \library\XenForo\BbCode\Formatter\Base.php on line 1110:
Find

        else
        {
            $name = false;
        }

Replace with

        else
         {
             $name = false;
             $source = false;
          }

I'm asking of this, because I've got an error (Method XenForo_BbCode_TextWrapper::__toString() must not throw an exception) while processing quote bbcode without options in my add-on.
Code of My_ViewPublic_Post class (from my test add-on):

class My_ViewPublic_Post extends XenForo_ViewPublic_Base
{
    public function renderHtml()
    {
        $bbCodeParser = new XenForo_BbCode_Parser(XenForo_BbCode_Formatter_Base::create('Base', array('view' => $this)));
        $this->_params['messageParsed'] = new XenForo_BbCode_TextWrapper($this->_params['message'], $bbCodeParser);
    }
}

That happens because of undefined variable $source in the source code (\library\XenForo\BbCode\Formatter\Base.php) in line 1120:

        if ($this->_view)
        {
            $template = $this->_view->createTemplateObject('bb_code_tag_quote', array(
                'content' => $content,
                'nameHtml' => $name,
                'source' => $source
            ));
            return $template->render();
        }

 

[Mike]

I'm surprised this hasn't been triggered before TBH, but fixed regardless. Thanks.

 

[Kaiser]

I'm surprised this hasn't been triggered before TBH, but fixed regardless. Thanks.

Should I wait for the next release, or just update it myself?

 

[Paul B]

Should I wait for the next release, or just update it myself?

Unless you're having issues due to the bug then just wait for the next release.