Fixed TypeError: array_merge(): Argument #1 must be of type array, bool given src/XF/Http/Reader.php:118

[Kirby]

Affected version

2.2.10 PL 1

$ips = array_merge(
    $data['ipv4s'],
    array_map(
        function ($ipv6) { return '[' . $ipv6 . ']'; },
        $data['ipv6s']
    )
);

So $data['ipv4s'] is a bool here - this seems to happen if the name cannot be resolved using IPv4:

    public function isRequestableUntrustedUrlExtended($url, &$data = [], &$error = null)
    {
        [...]
   
        $ips = @gethostbynamel($parts['host']);
        if ($ips)

        [...]

        $data = [
            'scheme' => $parts['scheme'],
            'host' => $parts['host'],
            'port' => $parts['port'] ?? null,
            'ipv4s' => $ips,
            'ipv6s' => array_column($ipv6s, 'ipv6')
        ];
        return true;

So in case an IPv6 resolution is successful (but IPv4 isn't) the function returns true, but ipv4s remains false (should be an empty array instead).

Btw: Why doesn't this entirely new method have a return type?

 

[mazzly]

Yep this also has been triggered for some of our AMPXF users and we'll probably need to add some temporary error suppression for this version..

 

[Chris D]

Fixed for the next release, thanks!

Btw: Why doesn't this entirely new method have a return type?

Not sure to be honest, may have just been missed in this case.

 

[freakyshiat]

I am still seeing this issue with 2.2.11

 

[mattrogowski]

2.2.11 was a security release so would be bumped to 2.2.12 (or next maintenance release).