Transcoding media broken in XF 2.3.10 (404 video)

[M@rc]

Affected version

2.3.10

Just uploaded a test video to the XFMG and it doesn't work:

hiEYZnxOt1acXCOd.mp4

• M@rc
• Yesterday at 5:51 PM

No alert that the video has been transcoded and the video is stuck at 0:00. Check the Console and you'll see it's a 404.

I'm sure you'll see an error in the XF Server Error Log.

I'm thinking it's because of this:

M

Fixed Thread 'Video transcoding deletes original file before new one saved'

Sep 12, 2024

XFMG\Service\Media\Transcoder::finalizeTranscode():

File::deleteFromAbstractedPath($queueData['fileName']);

clearstatcache();
$updates = [
    'file_hash' => md5_file($outputFile),
    'file_size' => filesize($outputFile),
];

$data = $attachment->Data;
$data->bulkSet($updates);
if (!$data->save(false, false))
{
    $this->transcodeException($queueData);
}
$finalPath = $data->getAbstractedDataPath();

File::copyFileToAbstractedPath($outputFile, $finalPath);

The original path is deleted first, but if anything errors during this step the transcoding will just fail and the...

• mattrogowski
• Replies: 1
• Forum: Media Gallery resolved bugs

• 

@Chris D any quick patch for this?