Fixed Thumbnail rebuild doesn't check if FFmpeg is available

[ibaker]

Thanks Chris...now down to just 8 errors:

Server error log

    LogicException: Video thumb rebuild for media item #4016: The path provided was not valid. src/addons/XFMG/Ffmpeg/Runner.php:29

    Generated by: Admin Mar 9, 2018 at 11:42 AM

Stack trace

#0 src/addons/XFMG/Ffmpeg/Runner.php(15): XFMG\Ffmpeg\Runner->setFfmpegPath('', true)
#1 src/addons/XFMG/Service/Media/ThumbnailGenerator.php(104): XFMG\Ffmpeg\Runner->__construct(false)
#2 src/addons/XFMG/Repository/Media.php(741): XFMG\Service\Media\ThumbnailGenerator->getTempThumbnailFromFfmpeg('/home/rfcom/pub...', 'data://xfmg/thu...', 'video')
#3 src/addons/XFMG/Job/MediaThumb.php(67): XFMG\Repository\Media->rebuildFFmpegThumb(Object(SV\ContentRatingsXFMG\XFMG\Entity\MediaItem))
#4 src/XF/Job/Manager.php(241): XFMG\Job\MediaThumb->run(8)
#5 src/XF/Job/Manager.php(187): XF\Job\Manager->runJobInternal(Array, 8)
#6 src/XF/Job/Manager.php(103): XF\Job\Manager->runJobEntry(Array, 8)
#7 src/XF/Admin/Controller/Tools.php(120): XF\Job\Manager->runByIds(Array, 8)
#8 src/XF/Mvc/Dispatcher.php(249): XF\Admin\Controller\Tools->actionRunJob(Object(XF\Mvc\ParameterBag))
#9 src/XF/Mvc/Dispatcher.php(88): XF\Mvc\Dispatcher->dispatchClass('XF:Tools', 'RunJob', 'html', Object(XF\Mvc\ParameterBag), 'tools', Object(XF\Admin\Controller\Tools), NULL)
#10 src/XF/Mvc/Dispatcher.php(41): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#11 src/XF/App.php(1889): XF\Mvc\Dispatcher->run()
#12 src/XF.php(328): XF\App->run()
#13 admin.php(13): XF::runApp('XF\\Admin\\App')
#14 {main}

Request state

array(4) {
  ["url"] => string(24) "/admin.php?tools/run-job"
  ["referrer"] => string(58) "https://www.recreationalflying.com/admin.php?tools/run-job"
  ["_GET"] => array(1) {
    ["tools/run-job"] => string(0) ""
  }
  ["_POST"] => array(3) {
    ["_xfRedirect"] => string(68) "https://www.recreationalflying.com/admin.php?tools/rebuild&success=1"
    ["_xfToken"] => string(8) "********"
    ["only_ids"] => string(4) "1136"
  }
}

 

[Chris D]

That looks like a bug so we'll look at that for the next release.