Lack of interest Thread Condition FIRST_POST should include post id...

[Jaxel]

Line 147 on XenForo_Model_Thread

			if ($fetchOptions['join'] & self::FETCH_FIRSTPOST)
			{
				$selectFields .= ',
					post.message, post.attach_count';
				$joinTables .= '
					INNER JOIN xf_post AS post ON
						(post.post_id = thread.first_post_id)';
			}

What good is having attach_count if you can't retrieve attachments without a post_id? Shouldn't this be changed to:

			if ($fetchOptions['join'] & self::FETCH_FIRSTPOST)
			{
				$selectFields .= ',
					post.post_id, post.message, post.attach_count';
				$joinTables .= '
					INNER JOIN xf_post AS post ON
						(post.post_id = thread.first_post_id)';
			}

 

[Mike]

first_post_id is already there

 

[ragtek]

Isn't it already there?

Edit
Oh, mike was faster