The config.php switch to disable emails is not working in my add-on

[AndyB]

Hello,

In my add-on I have the following which sends emails:

// prepare mail variable
$mail = XenForo_Mail::create('weeklydigest_contact', $params);

// send mail
$mail->queue($user['email'], $user['username']);

In testing I see the following code entered into the config.php is not working to stop emails from being sent.

$config['enableMail'] = 'false';

Should I add some code to my add-on to prevent this issue, or is the code in XenForo not working correctly?

Thank you.

 

[Chris D]

The queue method of the mail class should already prevent emails from being sent if the config has mails disabled, e.g.

if (!XenForo_Application::get('config')->enableMail)
{
   return true;
}

 

[AndyB]

The queue method of the mail class should already prevent emails from being sent if the config has mails disabled, e.g.

Yes I saw that in the code, and I would assume that bit of code would prevent emails from going out, but it does not.

 

[Chris D]

I missed it when I first looked.

'false'

and

false

is not the same thing.

The string 'false' will essentially evaluate to boolean value true.

Change your config.php to:

$config['enableMail'] = false;

 

[AndyB]

Brilliant.

Thank you kindly, Chris.