Lack of interest [Suggestion] LIMIT to Session Query

[DregondRahl]

Sessions can get quite large for an active community, so it would appropriate i think to add LIMIT 1 to the session query, so it stops searching after it find the one its looking for.

SELECT session_data, expiry_date
FROM xf_session
WHERE session_id = ?
LIMIT 1

Its not a major change but for a lot of sessions it can have some improvement.

 

[Mike]

The session ID is the primary key anyway (thus unique).

 

[Laric]

But it would have an effect anyhow especially if the mysql server is on another host wouldn't it?

 

[Mike]

No.

 

[Kier]

LIMIT works by doing the query, then extracting a collection of results.

When the query can only return a single result, by virtue of {unique_key} = {value}, then adding a LIMIT clause could not have any effect whatsoever.

 

[Vladislav Rastrusny]

Good explanation on the point here:
http://stackoverflow.com/questions/...limit-1-when-querying-on-indexed-unique-field

 

[DregondRahl]

Thanks for the input everyone, i guess because its indexed it wouldn't matter. =]