1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Implemented [Suggestion] Change the Smilie Cache to sort by Title instead of Smilie_ID

Discussion in 'Closed Suggestions' started by Kevin, Aug 2, 2013.

  1. Kevin

    Kevin Well-Known Member

    In the ACP the Smilies definitions are displayed alphabetically by their title and when viewing them on the Help page. When viewing the list of smilies from the editor they are instead displayed by their table ID instead.

    To be consistent the suggestion is to change /Model/Smilie.php so that the query for getAllSmiliesForCache is ordered by 'title' instead of 'smilie_id' as current.

    This would also allow us to group similarly themed smilies together based upon their name so that we could have a bit of control over how they are displayed in the editor.
     
    Sheldon likes this.
  2. Brogan

    Brogan XenForo Moderator Staff Member

    I prefer it as it is as it allows me to order the smilies as I want, either by adding them to the DB in the correct order, or by manipulating the ID in the database.

    I would hate them to be sorted by title in the editor.
     
  3. Kevin

    Kevin Well-Known Member

    Manually modifying the DB id directly is something that some admins might not want to play with. Presenting them the same way in all places is something that any admin could easily work worth with within the existing ACP screen.

    And I hate that they are sorted by id in the editor. Two sides of every coin.
     
  4. Brogan

    Brogan XenForo Moderator Staff Member

    The current situation gives admins the option.
    If you want them sorted by title just add them in the correct order.

    Currently both you and I can sort them how we want.
    If this suggestion was implemented only you would be able to sort them how you wanted.
     
  5. Kevin

    Kevin Well-Known Member

    Except, of course, when they go to add new ones then their only option is to manually manipulate the DB ids.

    Actually, no, I can't sort them how I want from within XF. I can do something ugly like manually modify table entries or manually edit the query code but not from within XF.
     
  6. Brogan

    Brogan XenForo Moderator Staff Member

    You don't need to manually edit the database. You can do it from within XF.

    If you want to add new smilies you can delete them and re-add them in the correct order.
     
  7. Kevin

    Kevin Well-Known Member

    Oh, yeah, that is so much better than having XF display them consistently while giving admins the ability to do simple grouping within the existing ACP tools as a bonus. :censored:
     
  8. Sheldon

    Sheldon Well-Known Member

    Seems like it would be extremely helpful to have a number beside the Smilie area in the AdminCP to show display order.
     
    xf_phantom, Shelley, Alien and 2 others like this.
  9. Slavik

    Slavik XenForo Moderator Staff Member

    Display priority as is in nodes... best solution for everyone...
     
    Alien, Sheldon and The Forum Heroes like this.
  10. The Forum Heroes

    The Forum Heroes Well-Known Member

    +10000000000 Totally agree!
     
  11. Shelley

    Shelley Well-Known Member

  12. Sheldon

    Sheldon Well-Known Member

  13. Kevin

    Kevin Well-Known Member

    Yep, having a sort option in the Smilie manager is the ideal way of dealing with it but it'll require database & GUI changes. While we wait for some type of change in a future update, having them sorted by title in the editor, the same way they are sorted on the help page and in the ACP, is literally a one word change in one file that would've allowed people to do some rudimentary sorting in the interim without having to resort to manual db changes or code changes.

    A quick & simple change that would've benefited people. Oh, well, I tried at least. I'll go back to keeping quiet. :censored:
     
    Sheldon likes this.
  14. Slavik

    Slavik XenForo Moderator Staff Member


    Both would still require an update.

    Why not do it right the first time ;) You could still make your change and release it as a resource in the interim...
     
  15. Kevin

    Kevin Well-Known Member

    Yeah, because changing one word will take the same amount of time & effort as implementing something that would require GUI and/or db changes. (y)

    Don't worry, I've learned my lesson. Going forward I'll be :censored:.
     
  16. Jeremy

    Jeremy XenForo Moderator Staff Member

    I think Slavik was more or less saying that a smilie manager with display order or some other advanced order management would be out of scope for 1.2. Both suggestions are valid.
     
  17. whynot

    whynot Well-Known Member

    How to do it?
     
  18. whynot

    whynot Well-Known Member

    Any link to it?
    I'm facing a real mess there.
     
  19. Jeremy

    Jeremy XenForo Moderator Staff Member

    Kevin and whynot like this.
  20. Brogan

    Brogan XenForo Moderator Staff Member

    Edit the smilie_id value in the xf_smilie table.
     
    whynot likes this.

Share This Page