Lack of interest [suggestion/bug?] Allow absolute paths for $config['development']['directory']

[Mike Tougeron]

Would it be possible to allow absolute paths for $config['development']['directory'] ?

XenForo_Model_Template::getTemplateDevelopmentDirectory() line 459:

if ( substr($config->development->directory, 0, 1) == '/' )
{
    return $config->development->directory . '/file_output/templates';
}
else
{
    return XenForo_Application::getInstance()->getRootDir() . '/' . $config->development->directory . '/file_output/templates';
}

 

[ragtek]

hm?

you set the developer directory via absolut path.
/file_output/templates file_output/admin_perm and all the other paths are set in the datawriters model

I've rewriten this and i'm using it for my add-ons http://xenforo.com/community/threads/config-development.5325/#post-237992

 

[Mike Tougeron]

you set the developer directory via absolut path.

Nope. The current code prefixes the setting with XenForo_Application::getInstance()->getRootDir(). I want the development directory to be *outside* of the rootDir and I didn't want to use '../../'

I've rewriten this and i'm using it for my add-ons http://xenforo.com/community/threads/config-development.5325/#post-237992

Yeah, I'm working on a patch for this as well so that it saves off every change someone makes so that we can save it into git. Working on another add-on that'll import templates for you as part of a "publish" process.

 

[ragtek]

Nope. The current code prefixes the setting with XenForo_Application::getInstance()->getRootDir(). I want the development directory to be *outside* of the rootDir and I didn't want to use '../../'

Sorry you're right. That's the standard behaviour in xf. I've forgotten that i changed this too.

 

[Jeremy]

Nope. The current code prefixes the setting with XenForo_Application::getInstance()->getRootDir(). I want the development directory to be *outside* of the rootDir and I didn't want to use '../../'

Yeah, I'm working on a patch for this as well so that it saves off every change someone makes so that we can save it into git. Working on another add-on that'll import templates for you as part of a "publish" process.

I like this. Do you plan to release this?

 

[Mike Tougeron]

I like this. Do you plan to release this?

Probably not. Depends on how 1.1.0-b3 works (I haven't had a chance to test it yet) since that allows you to use templates directly from the file system.

 

[Jeremy]

Probably not. Depends on how 1.1.0-b3 works (I haven't had a chance to test it yet) since that allows you to use templates directly from the file system.

I don't have a link on hand, but I know Kier said it is compiled versions, so we can't utilize it to send templates to something via git, and have the <xen: syntax written and such. Something like this would be very useful for me.

 

[Mike Tougeron]

Yeah, I need to look at the latest code before I decide for sure.