Fixed [Speed Up] No need to rebuild moderation queue if no rows affected

[guiltar]

Hello!

There is a method.

    public function deleteFromModerationQueue($contentType, $contentIds)
    {
       ....

        $db = $this->_getDb();
        $db->delete('xf_moderation_queue',
            'content_type = ' . $db->quote($contentType) . ' AND content_id IN (' . $db->quote($contentIds) . ')'
        );

        $this->rebuildModerationQueueCountCache();
    }

I suggest not to rebuild moderation queue if no rows affected. It causes db locks if the content is being deleted often. Suggestion:

    public function deleteFromModerationQueue($contentType, $contentIds)
    {
       ....
        $db = $this->_getDb();
        $affectedRows = $db->delete('xf_moderation_queue',
            'content_type = ' . $db->quote($contentType) . ' AND content_id IN (' . $db->quote($contentIds) . ')'
        );
        if($affectedRows)
             $this->rebuildModerationQueueCountCache();
    }

 

[Mike]

Seems reasonable, though we do assume that the moderation queue is small at any given time so it shouldn't be a significant change (though it does save a select and some updates).

 

[Marcus]

With a broader anount of spam keywords and lots of activity I had some hundred entries on the queue for some time. It worked then but having it faster is nice