Fixed Some manual rebuild jobs never complete

[Astra]

In update 2.1.6, this tank has not been fixed. All the same, at the top of the forum is a strip with a proposal for manual rebuilding.
Press the button - manual rebuild and after half an hour the strip is again at the top of the forum.

 

[Chris D]

Well the bug was a rather nasty server error so I am confident it is fixed.

If there is a manual rebuild job outstanding then the banner will display. This is the expected behaviour.

Once you continue running the jobs you need to leave your browser window open otherwise the job can’t complete.

 

[Astra]

Do I need to go into rebuilding the forum caches and select rebuilding reactions there? Is that all right?
Then wait until the complete rebuild and the banner after this disappears?



Or should I press manual rebuild on the banner itself?

I just rebuilt in both the first and second cases, but the banner appeared again after half an hour.

I waited for the rebuilding and saw a green inscription about the rebuilding of reactions.

I can give all access to the forum and you yourself can check this error.

The error occurs in two forums, in the third I did not rebuild caches for 3 months and there are no bars suggesting manual rebuilds.

 

[kelle67]

Same problem here.

 

[D.O.A.]

And here, with 2.1.6.

 

[soloarquitectura]

Same problem (manual rebuild job banner appeared again after a while) in two different forums with 2.1.6 Patch 1.

 

[Chris D]

Can you all take a look inside your xf_job table and let us know what you see?

I’m not able to reproduce the situation you’re reporting.

 

[kelle67]

Yes of course @Chris D

 

[Astra]

And my

 

[Chris D]

This is indeed not related to the original bug report where these posts were made, and actually not related to changes in XF 2.1.6, but changes we made in XF 2.1.5.

I can see the issue, and should be able to provide a workaround shortly.

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.1.7).

Change log:

Ensure that some jobs do not attempt to complete or otherwise change state inside a transaction.

There may be a delay before changes are rolled out to the XenForo Community.

 

[Chris D]

In the file src/Job/ReactionIsCounted.php find:

$db->beginTransaction();

And remove that line.

Then find:

$reactionRepo->recalculateReactionIsCounted($this->data['type'], $reactions);

And directly above it add:

$db->beginTransaction();

Then when you click "Continue running them" the job will finish properly.

 

[D.O.A.]

In the file src/Job/ReactionIsCounted.php find:

Thanks for this, I think you might have left XF out of the path though (src/XF/job/ReactionIsCounted.php)

 

[kelle67]

Thank you @Chris D.

 

[C6ckneyGeezer]

Thanks for this small fix @Chris D This was really bugging me....

 

[beerForo]

In the file src/Job/ReactionIsCounted.php find:

src/XF/Job

 

[C6ckneyGeezer]

I now get this error...

There are 1 missing files or files with unexpected contents. You should review these.

I assume it due to me changing this file. I should just ignore and it will fix itself next update?

 

[bzcomputers]

...I should just ignore and it will fix itself next update?

Yes