Fixed Smilies and images getting removed from editor automatically after inserting

[Andro]

Affected version

2.1.3

Strange issue after upgrading to 2.1.3

To reproduce:

Enter any/a few emojis and hit enter. Emojis will be deleted. Same happens with images too. They didn't show up and get auto deleted after clicking on insert (note: we are trying with remote images via URLs).

This is causing huge inconvenience as members are unable to upload any media. They can enter emojis from other editors like mobile phone and keyboard, those work as they are utf8 based emojis which converts into image only upon submission.

Everything was fine before the upgrade.

 

[Chris D]

I think we need more information from you exactly how these smilies and defined. Particularly you mention something about remote images? That might be key to us reproducing the issue.

Clearly the issue isn’t happening here so there must be something specific about the smilies which get deleted. If you can share the details of the smilies such as the image replacement URL etc that will be helpful.

 

[XF Bug Bot]

Thank you for reporting this issue. It has now been resolved and we are aiming to include it in a future XF release (2.1.4).

Change log:

Fix some slightly over-zealous image removal code in the editor if image uploads are not supported.

Any changes made as a result of this issue being resolved may not be rolled out here until later.

 

[Chris D]

The issue seems specific to the fact that you have image uploads disabled in the editor.

If you can download this file and upload it to your server and replace the existing js/xf/editor-compiled.js file, that should sort it. You might need to hard refresh in the browser for the new file to be picked up.

If after a hard-refresh the issue does not appear to be fixed, you can go to your install page and "Rebuild master data". This will simply rebuild some caches and change our JavaScript cache buster strings.

 

[swiftyste]

You can add +1 on to this before the upgrade everything was good but now both images and smiles are being removed from my self and my members.

 

[Chris D]

No need for the +1, it is now fixed and I provided a fix above.

 

[swiftyste]

No need for the +1, it is now fixed and I provided a fix above.

Thanks for that all good now!

 

[HotRodCarts]

Never mind I got it sorted out.

 

[deslocotoco]

The issue seems specific to the fact that you have image uploads disabled in the editor.

If you can download this file and upload it to your server and replace the existing js/xf/editor-compiled.js file, that should sort it. You might need to hard refresh in the browser for the new file to be picked up.

I just tried that but the problem persists. I don't disabled any image uploads.

I did opened the Forum in the Private Navigation to have a clear cache, but I'm still facing the problem.

I reported too this issue, but didn't see this thread before, so, sorry.

Btw, the health check:

 

[SeToY]

Btw, the health check:

That is to be expected as you, in fact, altered the files by overwriting a single one of them with the file Chris provided.

 

[dknife]

Confirmed the updated javascript has resolved this issue for me as I do not have attachment upload enabled for regular users.

 

[goobernacular]

For anyone needing to patch this issue, I can confirm the JS file shared above does work. You can read more about my own issues here to see if they match yours or not.

 

[nodle]

I sure hope we get a small 2.1.4 release soon to patch this, quite a bad bug.

 

[Chris D]

The issue seems specific to the fact that you have image uploads disabled in the editor.

If you can download this file and upload it to your server and replace the existing js/xf/editor-compiled.js file, that should sort it. You might need to hard refresh in the browser for the new file to be picked up.

If after a hard-refresh the issue does not appear to be fixed, you can go to your install page and "Rebuild master data". This will simply rebuild some caches and change our JavaScript cache buster strings.

The fix is right here.

 

[nodle]

The fix is right here.

Ya but I read doing this throws up errors for modified files, I’d rather have an error free ACP.

 

[Chris D]

It’s not an error. It’s an informational notification that simply says a file has been modified. Which you can just ignore because you know why it was modified!

 

[HappyWorld]

you can go to your install page and "Rebuild master data". This will simply rebuild some caches and change our JavaScript cache buster strings.

If i do "rebuild master data", will i lose custom phrase change & template change that i manually did (not from template modification system)?

 

[Chris D]

If you did then in the usually hidden master language or style then, yes.

If you did it on a language or style you created or added then no.

 

[PeterUwe89]

Shocked after update, but with activating the attechmet-function it works again.

 

[Chris D]

In case you missed it, the instructions for the fix are here:

The issue seems specific to the fact that you have image uploads disabled in the editor.

If you can download this file and upload it to your server and replace the existing js/xf/editor-compiled.js file, that should sort it. You might need to hard refresh in the browser for the new file to be picked up.

If after a hard-refresh the issue does not appear to be fixed, you can go to your install page and "Rebuild master data". This will simply rebuild some caches and change our JavaScript cache buster strings.