Duplicate Smiley button does not work in the ACP area

[tenants]

Affected version

v2.3.4

The bug:
/forum/admin.php?button-manager/edit&type=toolbarButtonsXS

If you click a smiley there, it does not insert, most of the other functionality does work


I think... Im still digging, but the data-href="{{href}}" is not getting replaced, if you log out:

let menuHtml = document.querySelector('.js-xfEditorMenu').textContent.trim()
console.log(menuHtml)

but that could be a red herring
-----

I only noticed this because I wanted to add a text editor (with smiles) to an ACP plugin I am developing:

    <xf:formrow label="{{ phrase('x') }}" hint="supports bbcode">
        <xf:editorrow
            name="description"
            value="{$x.description}"
            rowtype="fullWidth noLabel"
            placeholder="{{ phrase('x') }}"
            label="{{ phrase('x') }}"
            data-xf-init="editor"
        />
    </xf:formrow>

 

[Jeremy P]

I can't reproduce this on XF 2.3.6, smilies and emojies are inserted correctly. I do remember fixing some obscure editor insertion issues a while back, but I think it was prior to v2.3.4.

 

[tenants]

Dang it, upgraded and it works fine (although lost my local config.php while upgrading, thats a hassle - sorted)

Yup, seems to be an old bug you fixed