Signature Once 2.0.8

[Nirjonadda]

By user you mean the visitor or the post owner?

For both.

 

[Nirjonadda]

Do you able to replicate this issue?

 

[TickTackk]

Nope.

 

[Nirjonadda]

Nope.

You can also check this issue in my test site and you have login info.

 

[TickTackk]

It's working as intended.

 

[Nirjonadda]

It's working as intended.

How its working from your side? Once installed then all signature removed from Post without 1st post and 2nd page 1st posts but add-on option aren't enabled. 2nd post 1st posts will remove after enabling options. I didn't think this add-on functionality working correctly. Does this add-on working this way?

 

[TickTackk]

Once you disable the option added by this add-on in ACP, it acts like "Signature Once Per Page".

 

[Nirjonadda]

Once you disable the option added by this add-on in ACP, it acts like "Signature Once Per Page".

I see, thank you for clarifying.

 

[Warchamp7]

Getting this error on the odd occasion, not sure what specifically is causing it to happen. Redacted forum specifics

[LIST]
[*]ErrorException: Template error: key() expects parameter 1 to be array, null given
[*]src/addons/TickTackk/SignatureOnce/XF/Entity/Post.php:45          
[/LIST]

Stack trace
       
#0 [internal function]: XF\Template\Templater->handleTemplateError(2, 'key() expects p...', '/-----/-----...', 45, Array)
#1 src/addons/TickTackk/SignatureOnce/XF/Entity/Post.php(45): key(NULL)
#2 [internal function]: TickTackk\SignatureOnce\XF\Entity\Post->canShowSignature()
#3 src/XF/Template/Templater.php(939): call_user_func_array(Array, Array)
#4 internal_data/code_cache/templates/l1/s58/public/message_macros.php(335): XF\Template\Templater->method(Object(SV\UserEssentials\XF\Entity\Post), 'canShowSignatur...', Array)
#5 src/XF/Template/Templater.php(662): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, Array)
#6 internal_data/code_cache/templates/l1/s58/public/post_macros.php(200): XF\Template\Templater->callMacro('message_macros', 'signature', Array, Array)
#7 src/XF/Template/Templater.php(662): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, Array)
#8 internal_data/code_cache/templates/l1/s58/public/thread_new_posts.php(44): XF\Template\Templater->callMacro('post_macros', 'post', Array, Array)
#9 src/XF/Template/Templater.php(1249): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array)
#10 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('public:thread_n...', Array)
#11 src/XF/Mvc/Renderer/Json.php(81): XF\Template\Template->render()
#12 src/XF/Mvc/Renderer/Json.php(65): XF\Mvc\Renderer\Json->renderHtmlFallback('XF:Thread\\NewPo...', 'public:thread_n...', Array)
#13 src/XF/Mvc/Dispatcher.php(332): XF\Mvc\Renderer\Json->renderView('XF:Thread\\NewPo...', 'public:thread_n...', Array)
#14 src/XF/Mvc/Dispatcher.php(303): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#15 src/XF/Mvc/Dispatcher.php(44): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'json')
#16 src/XF/App.php(1931): XF\Mvc\Dispatcher->run()
#17 src/XF.php(328): XF\App->run()
#18 index.php(13): XF::runApp('XF\\Pub\\App')
#19 {main}

array(4) {
  ["url"] => string(97) "/threads/--------------------------.434391/add-reply"
  ["referrer"] => string(120) "https://-----.com/threads//--------------------------.434391/page-1325"
  ["_GET"] => array(1) {
    ["/threads//--------------------------./add-reply"] => string(0) ""
  }
  ["_POST"] => array(9) {
    ["message_html"] => string(1364) "<p>snip</p>"
    ["attachment_hash"] => string(32) "235f070ef4bcdba7bf8df6e99ed0df67"
    ["attachment_hash_combined"] => string(88) "{"type":"post","context":{"thread_id":434391},"hash":"235f070ef4bcdba7bf8df6e99ed0df67"}"
    ["last_date"] => string(10) "1528065823"
    ["last_known_date"] => string(10) "1528067672"
    ["_xfToken"] => string(8) "********"
    ["_xfRequestUri"] => string(97) "/threads//--------------------------.434391/page-1325"
    ["_xfWithData"] => string(1) "1"
    ["_xfResponseType"] => string(4) "json"
  }
}

 

[TickTackk]

@Warchamp7 Seems like there is incompatibility with @Xon's User Essentials add-on. Hoping he could grant me access so I can add compatibility for the add-on.

 

[Ozzy47]

@Warchamp7 Seems like there is incompatibility with @Xon's User Essentials add-on. Hoping he could grant me access so I can add compatibility for the add-on.

You should probably PC him and I am sure he will work with you.

 

[TickTackk]

@Warchamp7 Any steps to reproduce this? Do you get the same error when using default style?

 

[Warchamp7]

@Warchamp7 Any steps to reproduce this? Do you get the same error when using default style?

I don't have a reliable repro case currently. I just see it pop up in my error logs periodically. Does the stack trace have anything specific I should try to do for reproducing it?

 

[TickTackk]

Does the stack trace have anything specific I should try to do for reproducing it?

Yes and here is how you should be able to replicate

1. User X opens thread Y
2. User Z adds like 4-5 posts to thread Y
3. User X adds a reply which should trigger the "There are more posts to display." message to show

 

[Warchamp7]

Yes and here is how you should be able to replicate

1. User X opens thread Y
2. User Z adds like 4-5 posts to thread Y
3. User X adds a reply which should trigger the "There are more posts to display." message to show

That's what I was guessing too. I have a tab open of a relatively active thread and will test that shortly.

 

[Warchamp7]

Yes and here is how you should be able to replicate

1. User X opens thread Y
2. User Z adds like 4-5 posts to thread Y
3. User X adds a reply which should trigger the "There are more posts to display." message to show

Update: I couldn't cause it directly myself, but I did get a couple new entries in the error log while I tried.

I -think- this is related to viewing a newly added post, when it's a post from a new page?

Two of the entries in my error log were generated by users who added a post to the thread which was the start of a brand new page. So technically their sig should be shown as it's the only instance on the page in the posts' context, but visually it's getting added to the page the user is on where that sig may already be visible once

 

[TickTackk]

@Warchamp7 Which version of add-on are you using?

 

[Warchamp7]

@Warchamp7 Which version of add-on are you using?

v1.0.0

 

[Breixo]

I don't have license for that add-on so I cannot a bug-fix for it.

Maybe @ThemeHouse can help?

I'mt getting a similar problem.
In my case, don't have TH Q&A installed, but I installed TH Reactions and their UIX theme:

ErrorException: Template error: key() expects parameter 1 to be array, null given src/addons/TickTackk/SignatureOnce/XF/Entity/Post.php:45
Generated by: xxxx2 Jun 7, 2018 at 11:45 PM
Stack trace
#0 [internal function]: XF\Template\Templater->handleTemplateError(2, 'key() expects p...', '/home/nginx/dom...', 45, Array)
#1 src/addons/TickTackk/SignatureOnce/XF/Entity/Post.php(45): key(NULL)
#2 [internal function]: TickTackk\SignatureOnce\XF\Entity\Post->canShowSignature()
#3 src/XF/Template/Templater.php(939): call_user_func_array(Array, Array)
#4 internal_data/code_cache/templates/l3/s28/public/message_macros.php(437): XF\Template\Templater->method(Object(ThemeHouse\Reactions\XF\Entity\Post), 'canShowSignatur...', Array)
#5 src/XF/Template/Templater.php(662): XF\Template\Templater->{closure}(Object(ThemeHouse\UIX\XF\Template\Templater), Array, Array)
#6 internal_data/code_cache/templates/l3/s28/public/post_macros.php(195): XF\Template\Templater->callMacro('message_macros', 'signature', Array, Array)
#7 src/XF/Template/Templater.php(662): XF\Template\Templater->{closure}(Object(ThemeHouse\UIX\XF\Template\Templater), Array, Array)
#8 internal_data/code_cache/templates/l3/s28/public/thread_new_posts.php(26): XF\Template\Templater->callMacro('post_macros', 'post', Array, Array)
#9 src/XF/Template/Templater.php(1249): XF\Template\Templater->{closure}(Object(ThemeHouse\UIX\XF\Template\Templater), Array)
#10 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('thread_new_post...', Array)
#11 src/XF/Mvc/Renderer/Json.php(81): XF\Template\Template->render()
#12 src/XF/Mvc/Renderer/Json.php(65): XF\Mvc\Renderer\Json->renderHtmlFallback('XF:Thread\\NewPo...', 'public:thread_n...', Array)
#13 src/XF/Mvc/Dispatcher.php(332): XF\Mvc\Renderer\Json->renderView('XF:Thread\\NewPo...', 'public:thread_n...', Array)
#14 src/XF/Mvc/Dispatcher.php(303): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#15 src/XF/Mvc/Dispatcher.php(44): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'json')
#16 src/XF/App.php(1931): XF\Mvc\Dispatcher->run()
#17 src/XF.php(328): XF\App->run()
#18 index.php(13): XF::runApp('XF\\Pub\\App')
#19 {main}

Any help? Did you and @ThemeHouse talked?
Thanks!

 

[TickTackk]

@Breixo and @Warchamp7 are you using signature once per thread or per page?