Signature counter is not validated when validating passkey signature

K

Kirby

Well-known member
Affected version
2.3.0 Beta 3
When validating a passkey signature in \XF\Service\Passkey\Manager::validate() the signature counter is not checked.

Suggested Fix
Store the signature counter in entity Passkey after each successful validation and validate it when validating a passkey signature.
 

Similar threads

K
  • Suggestion Suggestion
Documenting callback signature for code events is not standardized
Replies
0
Views
20
Kirby
K
ge66
account_preferences should not show the setting for signatures if there is no permission for signatures
Replies
0
Views
93
ge66
ge66
X
Entity relationships do not (always) validate 'primary' flag is accurate and may not hit the entity cache
Replies
0
Views
386
Xon
X
Kevin
  • Suggestion Suggestion
Lack of interest When in 'edit' mode, do not validate the URL when saving the feed if it is flagged as inactive
Replies
0
Views
379
Kevin
Kevin
stefanstp
Not a bug Captcha validation is not correct for creating new thread
Replies
3
Views
885
Jeremy P
Jeremy P
Back
Top Bottom