Fixed Setting of version data in the DataWriters

xf_phantom

Well-known member
This is related to http://xenforo.com/community/threads/phrases-with-wrong-version_id.47517/

In 1.1.5 this wasn't fixed, not sure if it's fixed for 1.2, so before mike forgets to fix:p this, here's my report
When the addon_is is changed, the version_id and version_string needs to be changed inside of the phrase & template datawriter too.


I've fixed this inside the admincontroller (see my patch), but i would suggest to move this to the datawriters and call while preSave.


Then this bug couldn't happen anymore and we wouldn't need to remember to call updateVersionId if we use the template or phrase DataWriter in own Scripts.
 

Attachments

Top Bottom