Not a bug Server error if Elasticsearch is not running

[AndyB]

Affected version

Enhanced search v2.2.2

If Elasticsearch is not running and you try to do a search the following server error is displayed:



If Elasticsearch is not running, it would be better to return this error phrase:

return $this->error(\XF::phrase('xfes_elasticsearch_server_could_not_be_reached'));

 

[DreamNetworks]

Nice suggestion ! If we want to know the details we will always check xf logs

 

[Rasmus Vind]

I believe XF only displays exceptions if DEBUG is enabled in your config.php. Otherwise it gives a less technical error.

Also. Normal users have no idea what ElasticSearch is and don’t care. All they need to know is that the page is temporarily unavailable.

 

[AndyB]

I believe XF only displays exceptions if DEBUG is enabled in your config.php

In my testing, same error is produced weather debug mode is enabled or not.

 

[Rasmus Vind]

My users don’t see these errors when they occur. I wonder if it is different if you are not admin or not logged in.

 

[webbouk]

I believe that error would only show in the ACP therefore only visible to admins with the correct permissions

 

[Paul B]

The error shows on the front end to any logged in member but only if debug mode is enabled.

 

[PaulB]

The error shows on the front end to any logged in member but only if debug mode is enabled.

I was observing different behavior: the trace was showing even with debug mode disabled.

Looking at \XF\ControllerPlugin\Error::actionException, it seems the logic is to display the error if the site is in debug mode or the current visitor is an admin. Otherwise, a generic error with no trace will be displayed.

 

[AndyB]

I just checked and indeed if I'm logged in a normal registered user and Elasticsearch is not running, I get a proper message like this:

 

[Jeremy P]

I don't think we'll be making any changes here. There are a number of places which make calls that will throw if a connection to Elasticsearch cannot be established, and indeed the exception is only displayed to administrators or while in debug mode. This shouldn't occur under normal circumstances anyway.