SEO (SEO2) [Deleted]

Hey @au lait

Thread pages are failing to pass the AMP validator. Am i doing something wrong?

You can see it here: https://validator.ampproject.org/#url=https://www.oroom.org/forum/threads/tributes-to-sir-michael-atiyah.55798/
this is only the normal thread URL!

https://validator.ampproject.org/#url=https://www.oroom.org/forum/threads/tributes-to-sir-michael-atiyah.55798/

AMP URL ishttps://validator.ampproject.org/#url=https://www.oroom.org/forum/amp-threads/tributes-to-sir-michael-atiyah.55798/


192832
 
I will add an option for XF and for AMP to specify which user groups the Google Analytics code will be output to.
Right?
Comes with the next version
I'm not too sure on AMP, but it'd definitely help reduce noise if admins, mods, staff in general weren't included in Analytics data for a better understanding on target audience.

With that said, it should still be overall selectable by the site admin on who not to show the Analytics code to.
 
this is only the normal thread URL!

https://validator.ampproject.org/#url=https://www.oroom.org/forum/threads/tributes-to-sir-michael-atiyah.55798/

AMP URL ishttps://validator.ampproject.org/#url=https://www.oroom.org/forum/amp-threads/tributes-to-sir-michael-atiyah.55798/


View attachment 192832
So it should work now?

AMP links should start appearing on google mobile search?
 
AMP is intended for mobile devices only. Google finds the AMP page itself. The thread contains a link to the AMP page.
 
I had few errors because of wrong less (maybe only in xF 2.1) but I fixed this.

192856

in less files there are not correct "&" at the end of few selectors, and max() also doesn't work, so I commented these lines :)


192857

another problem is with lazy loading in AMP, but now I don't know how to disable lazy loading in AMP mode :p
192858
 
Last edited:
@au lait got this error when access resource category view in admincp
Code:
ErrorException: [E_WARNING] Declaration of xenMade\SEO\XFRM\Admin\Controller\Category::categorySaveProcess(XFRM\Entity\Category $category) should be compatible with xenMade\EAS\XFRM\Admin\Controller\Category::categorySaveProcess(XF\Entity\AbstractCategoryTree $category) in src/addons/xenMade/SEO/XFRM/Admin/Controller/Category.php at line 0
XF::handlePhpError() in src/vendor/composer/ClassLoader.php at line 444
include() in src/vendor/composer/ClassLoader.php at line 444
Composer\Autoload\includeFile() in src/vendor/composer/ClassLoader.php at line 322
Composer\Autoload\ClassLoader->loadClass()
spl_autoload_call()
class_exists() in src/XF/Extension.php at line 172
XF\Extension->extendClass() in src/XF/App.php at line 2409
XF\App->extendClass() in src/XF/App.php at line 1278
XF\App->XF\{closure}() in src/XF/Container.php at line 228
XF\Container->create() in src/XF/App.php at line 2364
XF\App->controller() in src/XF/Mvc/Dispatcher.php at line 211
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 88
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 41
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 1934
XF\App->run() in src/XF.php at line 333
XF::runApp() in admin.php at line 13

Code:
ErrorException: [E_NOTICE] Undefined index: args src/XF/Error.php:234

Code:
#0 src/XF/Error.php(234): XF::handlePhpError(8, '[E_NOTICE] Unde...', '/home/nginx/dom...', 234, Array)
#1 src/XF/Error.php(202): XF\Error->buildTraceArgs(Array)
#2 src/XF/Error.php(154): XF\Error->buildTraceString(Object(ErrorException))
#3 src/XF/Error.php(123): XF\Error->getTraceStringFromThrowable(Object(ErrorException))
#4 src/XF.php(161): XF\Error->logException(Object(ErrorException), true, '', false)
#5 src/XF/Mvc/Dispatcher.php(95): XF::logException(Object(ErrorException), true)
#6 src/XF/Mvc/Dispatcher.php(41): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#7 src/XF/App.php(1934): XF\Mvc\Dispatcher->run()
#8 src/XF.php(333): XF\App->run()
#9 admin.php(13): XF::runApp('XF\\Admin\\App')
#10 {main}

All add-ons in the latest version!
 
I really like this add-on :)

You should know it's important to set bigger thumbnails (because by default, guests see thumbnails, not full pictures), you can write about this somewhere in description (with small thumbs I had errors in OG Debugger and images didn't work):

source: https://developers.facebook.com/docs/sharing/best-practices/

Link to Open Graph Debugger: https://developers.facebook.com/tools/debug/


Best format is 600x315px or 1200x650px:
View attachment 172203

smaller image:
View attachment 172204

Currently we need to set also fb:app_id in our forum <head>, so I dit it in this way: https://xenforo.com/community/threa...-share-on-facebook.143418/page-2#post-1237273

What about this request? Has the bigger og:image for Facebook have been implemented in SEO2 yet? Or it still shows the small thumbnail on the left on Facebook for each thread?

I am using xf 2.1, so I should not buy it? There are many who are using 2.1. So can't you please make it compatible for both 2.0 and 2.1 from now onwards as there won't any huge changes?
 
What about this request? Has the bigger og:image for Facebook have been implemented in SEO2 yet? Or it still shows the small thumbnail on the left on Facebook for each thread?

I am using xf 2.1, so I should not buy it? There are many who are using 2.1. So can't you please make it compatible for both 2.0 and 2.1 from now onwards as there won't any huge changes?
The thumbnail depend on your image size, if you use large image then of course big thumbnail!
 
In xF 2.1 and few threads I have error:

ErrorException: [E_WARNING] strpos() expects parameter 1 to be string, array given in src/addons/xenMade/SEO/XF/Pub/Controller/Thread.php at line 597
  1. XF::handlePhpError()
  2. strpos() in src/addons/xenMade/SEO/XF/Pub/Controller/Thread.php at line 597
  3. xenMade\SEO\XF\Pub\Controller\Thread->changeSeoFromRes() in src/addons/xenMade/SEO/XF/Pub/Controller/Thread.php at line 34
  4. xenMade\SEO\XF\Pub\Controller\Thread->actionIndex() in src/addons/Andy/SimilarThreads/XF/Pub/Controller/Thread.php at line 16
  5. Andy\SimilarThreads\XF\Pub\Controller\Thread->actionIndex() in src/addons/Andy/History/XF/Pub/Controller/Thread.php at line 12
  6. Andy\History\XF\Pub\Controller\Thread->actionIndex() in src/XF/Mvc/Dispatcher.php at line 321
  7. XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 248
  8. XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 100
  9. XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 50
  10. XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2177
  11. XF\App->run() in src/XF.php at line 392
  12. XF::runApp() in index.php at line 20[/quote]
and logs:
192891

  • ErrorException: [E_WARNING] strpos() expects parameter 1 to be string, array given
  • src/addons/xenMade/SEO/XF/Pub/Controller/Thread.php:597
  • Generated by: Unknown account
  • 17.01.2019 o 08:48
Stack trace
#0 [internal function]: XF::handlePhpError(2, '[E_WARNING] str...', '/usr/home/spoko...', 597, Array)
#1 src/addons/xenMade/SEO/XF/Pub/Controller/Thread.php(597): strpos(Array, 'noindex')
#2 src/addons/xenMade/SEO/XF/Pub/Controller/Thread.php(34): xenMade\SEO\XF\Pub\Controller\Thread->changeSeoFromRes(Object(XF\Mvc\Reply\View), NULL)
#3 src/addons/Andy/SimilarThreads/XF/Pub/Controller/Thread.php(16): xenMade\SEO\XF\Pub\Controller\Thread->actionIndex(Object(XF\Mvc\ParameterBag))
#4 src/addons/Andy/History/XF/Pub/Controller/Thread.php(12): Andy\SimilarThreads\XF\Pub\Controller\Thread->actionIndex(Object(XF\Mvc\ParameterBag))
#5 src/XF/Mvc/Dispatcher.php(321): Andy\History\XF\Pub\Controller\Thread->actionIndex(Object(XF\Mvc\ParameterBag))
#6 src/XF/Mvc/Dispatcher.php(248): XF\Mvc\Dispatcher->dispatchClass('XF:Thread', 'Index', Object(XF\Mvc\RouteMatch), Object(SV\MultiPrefix\XF\Pub\Controller\Thread), NULL)
#7 src/XF/Mvc/Dispatcher.php(100): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(SV\MultiPrefix\XF\Pub\Controller\Thread), NULL)
#8 src/XF/Mvc/Dispatcher.php(50): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#9 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#10 src/XF.php(392): XF\App->run()
#11 index.php(20): XF::runApp('XF\\Pub\\App')
#12 {main}
 
In xF 2.1 and few threads I have error:
This one's already fixed!

@au lait got this error when access resource category view in admincp
All add-ons in the latest version!

New version coming today
with Beta 4 there will also be a separate XF2.1 version!
 
Top Bottom