Fixed Search results only show pm's

[duderuud]

Affected version

2.3

When using the default search (everywhere), searching a member only just shows PM's instead of all the content by that username

 

[Chris D]

Huh... cool

 

[duderuud]

Another example, searching for all posts by @Russ :

XenForo community

xenforo.com

Also only shows PM's

 

[Ozzy47]

Ouch, this is not good.

Ohh wait, it's not that bad, it only shows conversations you can view.

 

[Paul B]

Ohh wait, it's not that bad, it only shows conversations you can view.

Yes, for the avoidance of doubt, as with all search results, only content you have access to is available.

The actual bug is that only DMs are being returned and no other content.

 

[Xon]

This actually blocks search working for guests entirely.

getTypePermissionConstraints needs to be significantly more complex than just:

return [
new MetadataConstraint('recipients', \XF::visitor()->user_id)
];

This is how I've implemented it in my conversation improvements add-on:

XenForo2-ConversationImprovements/upload/src/addons/SV/ConversationImprovements/Search/Data/ConversationMessage.php at main · Xon/XenForo2-ConversationImprovements

A collection of improvements to the XenForo Conversation system - Xon/XenForo2-ConversationImprovements

github.com

PermissionConstraint/AndConstraint/TypeConstraint/NotConstraint are part of Search Improvements, and I never did endup making an SQL variant of those but it should be doable

 

[stromb0li]

Would assume this is semi related; but search in bookmarks doesn't work as well (at least on XF website; haven't tried 2.3 yet locally).

 

[zappaDPJ]

Advanced search returns only the threads and Direct messages that I have participated in.

 

[Chris D]

Would assume this is semi related; but search in bookmarks doesn't work as well (at least on XF website; haven't tried 2.3 yet locally).

No not related.

 

[Chris D]

We've implemented a workaround here for this but the bug report is staying open for a more comprehensive fix.

 

[Chris D]

This is fully fixed in Beta 7 with the introduction of support for type-specific search constraints.