Fixed Search in resources section is sometimes returning results half screen like this...

[Neutral Singh]

Affected version

xF 2.x

No sure if it is already reported... Firefox 61.0.1 | MacOS High Sierra 10.13.2

Search in resources section is sometimes returning results half screen like this... I got the following screen at least thrice in one session...

 

[nocte]

Same if you search here -> https://xenforo.com/community/forums/xenforo-development-discussions.34/ for "privacy":

 

[Ehren]

This is happening when the search term appears inside a code block with other HTML elements. Code blocks don't seem to encode HTML symbols in the results page, which means when the textHighlight class is wrapped around the term, it breaks the rest of the page.

This is the HTML from the page source of a broken results page.

<div class="contentRow-snippet">I have two help pages, one for <em class="textHighlight">Privacy</em> Policy and another called Terms and Rules. They are being listed twice on my help page, but with slightly different descriptions:


<li><a href="/help/<em class="textHighlight">privacy</em>" class="primaryContent"><em class="textHighlight">Privacy</em> Policy</a></li>
<li><a href="/help/tos"...</div>

            <div class="contentRow-minor contentRow-minor--hideLinks">

 

[marquisite]

This is happening when the search term appears inside a code block with other HTML elements. Code blocks don't seem to encode HTML symbols in the results page, which means when the textHighlight class is wrapped around the term, it breaks the rest of the page.

I've experienced a related but less drastic 'endless bold' scenario, caused by matched search terms inside a code block.


The HTML for the affected search result shows that XF1 template code is being inserted as HTML. The xen:foreach even has the textHighlight class added. (post)

 

[Chris D]

This is a regression caused by a candidate fix for an issue in 2.0.8. It isn’t in the currently released version.

Thanks for your reports, we’ll make changes or rollback the fix.

 

[Chris D]

This has been rolled back, for now.