Search Improvements 2.17.7

[Xon]

I have that fixed for the next update, but I want todo more testing for releasing it.

 

[Sprisa]

Hello. I am having problems with the addon on xf v2.2.13

InvalidArgumentException: Unknown search handler type 'conversation' - src/XF/Search/Search.php:325

 

[Xon]

Hello. I am having problems with the addon on xf v2.2.13

Update the add-on, that appears to be from a very old version.

 

[Xon]

Xon updated Search Improvements with a new update entry:

2.17.6 - Bugfix & Maintenance update

• XF2.3.8 compatibility fix
• Adjust Collect search DSL & debug statistics so Log & show on search results only displays to members by defaults and not guests.

Read the rest of this update entry...

 

[Sprisa]

Update the add-on, that appears to be from a very old version.

I just downloaded the update you uploaded and this was from after that

 

[Xon]

I just downloaded the update you uploaded and this was from after that

Please post the actual stack trace and not a truncated screenshot of it, and when reporting please include what version of the add-on it is with.

Do you have Conversation Improvements installed? Or did you uninstall it at some point.

Can you run this SQL query? I need to see the search types list for your site.

select content_type,field_value,addon_id
from xf_content_type_field
where field_name = 'search_handler_class' and content_type in ('conversation','conversation_message');

 

[Sprisa]

Please post the actual stack trace and not a truncated screenshot of it, and when reporting please include what version of the add-on it is with.

Do you have Conversation Improvements installed? Or did you uninstall it at some point.

Can you run this SQL query? I need to see the search types list for your site.

select content_type,field_value,addon_id
from xf_content_type_field
where field_name = 'search_handler_class' and content_type in ('conversation','conversation_message');

• Conversation Improvements 2.5.1
• Search Improvements 2.17.5

That command returns No rows.

 

[Sprisa]

I can however see that something like that exists

 

[Xon]

I can however see that something like that exists
View attachment 332772

Please do a rebuild of the add-on, this should re-add the missing rows

 

[Xon]

Xon updated Search Improvements with a new update entry:

2.17.7 - Bugfix update

• Improve XF Cloud support
• Fix sorting by a custom elasticsearch field didn't work as expected when using SearchOrder class (ie Report Improvements and sorting reports by comment count)

Read the rest of this update entry...

 

[bzcomputers]

Does the data exist to increase the precision of the reported time averages in the admincp?

For example I always see 0 milliseconds...



It would be nice to see one or two additional decimal places in these locations if possible. I know sub millisecond times aren't very useful but when I see zero all the time it just makes me think the data is missing or there is an issue with the calculation itself.

Thanks.

 

[Xon]

Under the hood elasticsearch is reporting indexing.index_time_in_millis and indexing.index_total the average is being computed very simply but it is using the XF number formatting which truncates the decimal places.

The average is being computed like this:

{{ parens(phrase('xfes_x_milliseconds_average', {'time': number($esStats.indexing.index_time_in_millis / $esStats.indexing.index_total)})) }}

Definitely could adjust that number() to include some decimal places.