• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

Fixed RTL: No effect when side nav is opened in responsive

rellect

Well-known member
#1
Relevant code (acp_nav.js)
HTML:
if (newValue)
{
    $sidebar.addClass('active');
    recalcSidebarHeight();

    $sidebar.css('left', -$sidebar.width()).animate({left: 0}, function()
    {
        $sidebar.css('left', '');
        sidebarActive = true;
        sidebarTransitioning = false;
    });
}
else
{
    $sidebar.animate({left: -$sidebar.width()}, function()
    {
        $sidebar.css('left', '')
            .removeClass('active');
        sidebarActive = false;
        sidebarTransitioning = false;
    });
}
The above code does not reverse the effect for RTL.
Should be something like
HTML:
var slideDirection = XenForo.switchStringRTL('left'),
    animateOptions = function(value){
        var options = {};
        options[slideDirection] = value;
        return options;
    };

if (newValue)
{
    $sidebar.addClass('active');
    recalcSidebarHeight();

    $sidebar.css(slideDirection, -$sidebar.width()).animate(animateOptions(0), function()
    {
        $sidebar.css(slideDirection, '');
        sidebarActive = true;
        sidebarTransitioning = false;
    });
}
else
{
    $sidebar.animate(animateOptions(-$sidebar.width()), function()
    {
        $sidebar.css(slideDirection, '').removeClass('active');
        sidebarActive = false;
        sidebarTransitioning = false;
    });
}