1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed ResponceView Wrapper changes page_criteria

Discussion in 'Resolved Bug Reports' started by guiltar, Apr 7, 2013.

  1. guiltar

    guiltar Well-Known Member

    Hello Kier and Mike!

    I've started to code the Widget System based on user and page criteria (like notices).
    I was going to realize it as ResponseView Wrapper which adds widget params to container.
    But when one uses Wrapper method preRenderView in Front Controller takes parameters of Wrapper instead of inner Response params.
    For example, 'viewName' param is taken from Wrapper.

    I doubt that it's designed since even in the core many responces have same Wrapper.
    For instance, account wrapper is widely used.
     
    Goodspeed, Alluidh and Yoskaldyr like this.
  2. Mike

    Mike XenForo Developer Staff Member

    I've changed the preRenderView to pull from the sub view. I think the contentTemplate should already be correct because of how the code is structured. I should note that the params exposed to the page criteria check method (and event) will still be of the wrapper, I think. I'm not sure of a good way around that.

    I'm making this change only for 1.2.
     
    Yoskaldyr likes this.

Share This Page