Lack of interest Removal of unused editor icons from spritesheet

[Alien]

Hey,

I noticed the following spritesheet has a ton of icons that are not used in XF's implementation:
http://xenforo.com/community/styles/default/xenforo/editor/icons.png?redactor

I also noticed that if you remove "?redactor" the old colorful editor icons are still there?

Is this list going to be trimmed down before official release?

Thanks!

 

[Alien]

On an unrelated note, I've never seen quick replies submit faster than on 1.2! Very good performance-based boost too here!

Nice job guys!

 

[Shelley]

Good suggestion I was going to suggest this last night but got distracted.

 

[Luxus]

Actually http://xenforo.com/community/styles/default/xenforo/editor/icons.png and http://xenforo.com/community/styles/default/xenforo/editor/icons.png?redactor are the same spritesheet. I don't see any colored icons.

 

[Alien]

Actually http://xenforo.com/community/styles/default/xenforo/editor/icons.png and http://xenforo.com/community/styles/default/xenforo/editor/icons.png?redactor are the same spritesheet. I don't see any colored icons.

I had to do a hard-refresh. It had them cached the whole time. So ignore the original icons.png bit. Doesn't even matter if you do ?derp - still shows the same spritehsheet so is "?redactor" even necessary?

 

[Jeremy]

The ?redactor is a cache buster mechanism. Your browser had icons.png cached, but icons.png?redactor is a new resource for the browser, so it gets loaded and recached.

 

[Luxus]

I think Mike kept the spritesheet to save himself work and to allow future icons to be added. If he had removed all unused icons he had to correct the default CSS values for all icons. The file is just 20KB and is cached by your browser, so you need to download it once.

 

[Alien]

The ?redactor is a cache buster mechanism. Your browser had icons.png cached, but icons.png?redactor is a new resource for the browser, so it gets loaded and recached.

Smart move! Thanks!

 

[Alien]

I think Mike kept the spritesheet to save himself work and to allow future icons to be added. If he had removed all unused icons he had to correct the default CSS values for all icons. The file is just 20KB and is cached by your browser, so you need to download it once.

I think he'll eventually use his own spritesheet, I still think a pretty big portion of icons aren't used there (even if a few more features were added).

Sometimes first visit experience could be essential and the quicker the initial load on the page the better.

 

[dieketzer]

please dont strip out icons ppl might potentially want to use for the sake of a couple kb when you can save tons more by getting rid of all the gradient overlays.