Fixed Registration Fields Loss of Data

[Jeremy]

When a would-be registrant fails to fill out the form properly, custom fields that are drop downs and radios lose their value, while others retain it.

To reproduce:

1. Have 3 required (or shown) fields, 1 of each type (Drop down, radio, and checkbox)
2. Fill out the entire form, setting values for each field.
3. Intentionally fail captcha or password to cause the registration form to show again
4. Notice that the values for the checkbox are kept, and the values for the drop down and radio are lost.

Possible Regression from:
https://xenforo.com/community/threads/minor-issue-in-custom_field_edit.87586/
https://xenforo.com/community/threa...m-field-dropdowns-in-custom_field_edit.91386/

Tested and reproduced on multiple sites, on the default style, on 1.5.4.

 

[Mike]

I think the hasValue check that I added is unnecessary here (and likely confusing for the most part) and the cause of this. I've made some tweaks and I haven't seen any regressions yet.