XF 2.1 Regex Help

[Ozzy47]

I have this regex, <xf:if is="\$post\.edit_count && \$post\.canViewHistory\(\)".*\/>

It matches just about everything I am looking for in the post_macros template:

<xf:if is="$post.edit_count && $post.canViewHistory()">
                                                <a href="{{ link('posts/history', $post) }}"
                                                    class="actionBar-action actionBar-action--history actionBar-action--menuItem"
                                                    data-xf-click="toggle"
                                                    data-target="#js-post-{$post.post_id} .js-historyTarget"
                                                    data-menu-closer="true">{{ phrase('history') }}</a>

                                                <xf:set var="$hasActionBarMenu" value="{{ true }}" />
                                            </xf:if>

The only thing that is not included it the closing </xf:if> tag, and that needs to be included.

 

[MilkyMeda]

/<xf:if is="\$post\.edit_count && \$post\.canViewHistory\(\)\">(.|\s)+(<\/xf:if>)/

 

[Kirby]

#<xf:if is="\$post\.edit_count && \$post\.canViewHistory\(\)".*</xf:if>#sU

Using an OR (|) like @MilkyMeda suggested is also possible, but IMHO using the s-modifier so . also matches newlines is easier.

You'd also want to use the U-modifier so it also correctly works on this input (which is not the case with the regex @MilkyMeda suggested):

<xf:if is="$post.edit_count && $post.canViewHistory()">
                                                <a href="{{ link('posts/history', $post) }}"
                                                    class="actionBar-action actionBar-action--history actionBar-action--menuItem"
                                                    data-xf-click="toggle"
                                                    data-target="#js-post-{$post.post_id} .js-historyTarget"
                                                    data-menu-closer="true">{{ phrase('history') }}</a>

                                                <xf:set var="$hasActionBarMenu" value="{{ true }}" />
                                            </xf:if><xf:if is="$foo">foo</xf:if>

 

[Ozzy47]

/<xf:if is="\$post\.edit_count && \$post\.canViewHistory\(\)\">(.|\s)+(<\/xf:if>)/

Thanks, I just came up with this and it seems to work as well, <xf:if is="\$post\.edit_count && \$post\.canViewHistory\(\)".[I]\/>.[/I]<\/xf:if> which way is better?

 

[Ozzy47]

#<xf:if is="\$post\.edit_count && \$post\.canViewHistory\(\)".*</xf:if>#sU

I see there is multiple ways to do this.

 

[MilkyMeda]

<xf:if is="\$post\.edit_count && \$post\.canViewHistory\(\)".\/>.<\/xf:if>

I'm not sure this will work. I couldn't get it to match. This will match the letter 'I': [I]

That part seems irrelevant.

 

[MilkyMeda]

I see there is multiple ways to do this.

In RegEx, there is many ways to do one thing, always.

 

[Kirby]

I see there is multiple ways to do this.

There are almost always multiple ways to write a regex, but often they are not fully equal in terms of matching quality and speed. YMMV.

 

[Cupara]

EDIT: After testing @MilkyMeda his code is the best.

 

[Cupara]

To add to this topic, is there a way to search for tab newlines when using regex through template modifications?

 

[Kirby]

Are we talking about the same regex?

Please compare:
Regex MilkyMeda (1403 steps, matches more than one if)
Regex Kirby (728 steps, does not match more than one if)

 

[Cupara]

@Kirby
I see the difference now. After viewing @Kirby results I find that his initial testing is solid and would be the best option to go with.

 

[MilkyMeda]

Oh, I wasn't aware of the U modifier which gave me multiple headaches months ago in a regex-heavy project...

 

[Ozzy47]

Trying to do a $1 and $2 replacement. Can someone help with the regex?

#(<xf:macro name="feed_row" arg-item="!">.*?)(<\/li>.*?)#si

 

[Kirby]

I am not sure if I understand what you are trying to do ... you've got two star quantifiers (which are the only quantifiers) any you make each one of them ungreedy; imho it would be easiert tu read/understand to just use the U modifier in this case.

What are you trying to match and replace?

 

[Ozzy47]

Thanks for the reply..

In the news_feed_macros template, I am trying to find, <xf:macro name="feed_row" arg-item="!"> and add a opening if statement, then find </li> and add a closing if statement.

 

[Ozzy47]

Solved. /(<xf:macro name="feed_row" arg-item="!">)(.*?)(<\/xf:macro>)/s

 

[Ozzy47]

Okay, I am kinda stumped again. In the PAGE_CONTAINER template, I am wanting to search for this:

                    <img src="{{ base_url(property('publicLogoUrl')) }}" srcset="{$srcset}" alt="{$xf.options.boardTitle}"
                        width="{{ property('publicLogoWidth') ?: '' }}" height="{{ property('publicLogoHeight') ?: '' }}" />

Which I find easily like this:
/<img src="{{ base_url\(property\('publicLogoUrl'.+>/isU

Problem is, there are two instances of what I am searching for. I need to change the first one and second one to two different things.

So how can I stop the find after the first instance, and then find only the second instance?

 

[TickTackk]

Try with pattern:

#(<div class="p-header-logo.*?)(<img .*?\/>)(.*?<div class="p-nav-smallLogo.*?)(<img.*?\/>)#si

and replacement being

$1[     first logo replacement goes here     ]$3[      second logo replacement goes here      ]

I suggest you try playing with regex101 as it is very useful.

 

[Ozzy47]

That works perfectly.

I am using Regex 101, but obviously not that well.