Closed Rating percentage can be 100%+

[nocte]

Affected version

2.3.11

There seem be some fixed issues regarding voting percentage, e.g.:

K

Fixed Thread 'Incorrect % in rating count & the phrase appears in other languages'

Dec 24, 2024

In getResourceRatingSplit
We get this query:

$splitRatings = $this->app()->db()->fetchAllKeyed("
       SELECT rating,
              COUNT(*) AS total,
              (COUNT(*) / ?) * 100 AS percentage
       FROM xf_rm_resource_rating
       WHERE resource_id = ?
       AND rating_state = 'visible'
       GROUP BY rating
    ", 'rating', [$resource->review_count, $resource->resource_id]);

But this is an incorrect value, because we get the number of reviews, without rating. Instead of review_count, there should be rating_count
Accordingly, because of this, the %...

• kick
• Replies: 3
• Forum: Resource Manager resolved bugs

• 

I just found this here on XF.com:



Source:

Signup abuse detection and blocking - Reviews

xenforo.com

-> 104% positive ratings

 

[Chris D]

Turns out the rebuild that fixed it in 2.3.11 didn't run here. Have run it now and confirmed the bug is fixed. No further action required.

 

[smallwheels]

-> 104% positive ratings

It just shows that @Xon is really a very good developer.