• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

Not a bug Possible Route Path Bug

tenants

Well-known member
#1
I think this a bug (and not user issue)

I'm testing this locally (Windows 7) without friendly URLs

I've set
Board URL: http://localhost/xenforo/forum (since you ask not to use index.php or a trailing slash)
Index Page Route: forums/

Expected:
I'm expecting that clicking the forum nav will go to
http://localhost/xenforo/index.php?forum/

and forms will have the url
http://localhost/xenforo/index.php?forums/introductions.1/


Actual:
clicking the forum nav goes to
http://localhost/xenforo/index.php?forums/


(note, I have set XenForo_Link::setIndexRoute('homepage'); but without setting this, the forum nav goes to index.php and not index.php?forum/ )


P.S. do you have in house testers, I'm just around the corner :D
 

Mike

XenForo developer
Staff member
#2
I'm expecting that clicking the forum nav will go to
http://localhost/xenforo/index.php?forum/
I'm confused as to why that's expected? I don't see that URL appearing anywhere else.

The Index Page Route that you have set in the options has been completely overwritten by your setIndexRoute() call, so index.php will go to your "homepage" route. The forums now live at forums/ by default.

It all looks expected to me?
 

tenants

Well-known member
#3
So this is what I was expecting

With these 2 settings

Board URL: (The primary URL to your board) with the introduction of routes, this would now let me set the primary (actionIndex) of the forum to something else (this was my misunderstanding/ interpretation of primary URL)
Index Page Route: This would allow me to set all other routes for the forum /forums/introductions.1/ to /community/introductions.1/ etc

The problem is, the route changer here:
http://xenforo.com/community/threads/library-set-your-own-route-controller-as-homepage.10156/

uses
index.php for the site homepage
/forum for the forum homepage
/forums/introductions.1/ for forum controllers

so, moving over from that (without playing around with htaccess), there is no way of setting XenForo_ControllerPublic_Forum::actionIndex individually

The site is now set up as
index.php for the site homepage
/forums for the forum homepage
/forums/introductions.1/ for forum controllers

I guess the issue is, there is no way of setting XenForo_ControllerPublic_Forum::actionIndex individually (my expectations of Board URL are irrelevant if this was possible somewhere else)
 
Last edited:

Mike

XenForo developer
Staff member
#4
The board URL doesn't affect any routes or anything like that. It's just telling us where the board is when we need that URL (like in emails).

The index route simply defines what accessing <url>/index.php or <url>/ will access. Because of the setIndexRoute() call you made, this is your homepage. Since the forum list is no longer the index, it will return to its normal URL.

You're right that there's no way to target forums/ but not forums/something with the route filters - it's not designed to do that. It expects to change a hierarchy. You could suggest this, though I'm not sure exactly how possibly it would be (may well be). I'm not sure I see the advantage though.
 

tenants

Well-known member
#5
Advantages for a new sites, there will probably be none, although "forum" for the forum homepage and "forums" for their controllers does make grammatical sense (but you don't do that for threads or anything else, so that can be probably ruled out as an argument)

However, for existing sites that wish to upgrade (even some of the most well known plugins designers: 8wayrun.com/forum/ 8wayrun.com/forums/new-player-arena.92/ ) may have issues upgrading, since the route controller plugin mentioned above is now broken in 1.2, and you can not set XenForo_ControllerPublic_Forum::actionIndex individually with core methods

added suggestion: http://xenforo.com/community/thread...oro_controllerpublic_forum-actionindex.52990/
 
Last edited:

Jaxel

Well-known member
#6
Mike can't really give support for third-party plugins, and I wouldn't expect him to do so.

Anyone who uses XenPorta/XenUtiles should inherently know that 1.2 will change a lot of things for those mods and absolutely refrain from upgrading till they get the go ahead. This is the life of using third-party mods.