Shadab
Well-known member
Lines 176 - 178
Please consider changing _handleCustomPreloadedData() to accept the $data array by reference. In its current form, any missing data that gets preloaded via this method in a child class (XenForo_Dependencies_Public, for example) isn't reflected in the original $data array which gets passed to the event handlers for init_dependencies.
This is not an issue most of the time because whatever data that needs to be preloaded is usually present in the data registry.
PHP:
$this->_handleCustomPreloadedData($data);
XenForo_CodeEvent::fire('init_dependencies', array($this, $data));
Please consider changing _handleCustomPreloadedData() to accept the $data array by reference. In its current form, any missing data that gets preloaded via this method in a child class (XenForo_Dependencies_Public, for example) isn't reflected in the original $data array which gets passed to the event handlers for init_dependencies.
This is not an issue most of the time because whatever data that needs to be preloaded is usually present in the data registry.