Fixed Pasting link to reply goes to the first post

Mr Lucky

Mr Lucky

Well-known member
Affected version
2.3
If I paste this link which was actually to post #4, it ends up linking to and shows post#1 like this:

Paul

Thread 'Please could we have more options when it comes to paid "Upgrades"'

Hiya team!

Not made any Xenforo suggestions before, however figured i would give it a go.

Currently the way our site is set up, we rely soley on Donations to keep the place running. This is currently handled by the internal payment processor (third party ones either dont have the functionality or we have had issues with - the internal one is the only one that "just works" in my view...
The issue is that you can only "donate" once for an upgrade. Plus you can't add your own donation amount - it has to be the one set up. The upgrades actually are identical - they just give the ability to...

If I paste this link to post #42 it ends up linking to and shows post#1 like this:

P

Thread 'XF 2.3 feedback and comments'

Welcome to 2.3!

Post your feedback and comments here.

This post will be kept updated with feedback, known issues, bugs, and fixes.

If you are reporting something, tag me so I can add it to the list.


Issues
  • Like
  • Love
  • Wow
 
Last edited:
yeah you need to use links without #. so copy the link from the share menu in posts instead of the address bar of the browser.

https://xenforo.com/community/threads/please-could-we-have-more-options-when-it-comes-to-paid-upgrades.218463/post-1661043

https://xenforo.com/community/threads/xf2-3-feedback-and-comments.217957/post-1657392

the above links should embed just fine pointing to the correct post.

Paul

Post in thread 'Please could we have more options when it comes to paid "Upgrades"'

The issues i had were varied, however one Addon creator i reported a major problem to (users just randomly being dropped from the "site supporters" usergroup) just told me that it was "my system" and didnt want to support, and then a couple of others wouldnt support the obviously extensive requirements in their add-ons.

The inbuilt one works really well - it just doesnt cover the two aspects in my post above!

J

Post in thread 'XF 2.3 feedback and comments'

Paul B said:
[COLOR=hsl(var(--xf-editorFocusColor))]Gravatar broken[/COLOR]
Click to expand...
Is this a bug or just incorrect syntax?
 
Last edited:
Chromaniac said:
yeah you need to use links without #. so copy the link from the share menu in posts instead of the address bar of the browser.
Click to expand...
Yeah, this works - but the averge user will not understand the subtle difference between a permalink to the post (which works) and and a link to the thread page with post fragment (which does not work).

I therefore think that both should work.
 
Chromaniac said:
yeah you need to use links without #. so copy the link from the share menu in posts instead of the address bar of the browser.
Click to expand...

Kirby said:
Yeah, this works - but the averge user will not understand the subtle difference between a permalink to the post (which works)
Click to expand...
Absolutely they won't . They post links that they've copied from the address bar.

Especially since it works as they would expect in v 2.2 - why should it change in 2.3 to something unintuitive?
 
the thing is that # based links are not going to work in all circumstances. if the post is moved to another thread, # link would not work. if the forum administrator changes number of posts per page setting in backend, these links could potentially stop working again. so they are not really reliable permalinks to individual posts. there is no easy fix to the situation where users would share the link copied from the browser address bar. except maybe for xenforo to just ignore the thread number in the link and just focus on the post number.

on the other hand, they are offering an option to disabling auto-embed and retain the existing 2.2.x behavior where internal links would be processed similarly to external links.
 
there is no easy fix to the situation where users would share the link copied from the browser address bar. except maybe for xenforo to just ignore the thread number in the link and just focus on the post number.
Click to expand...
Actually I think it shouldn't be too difficult - just needs a bit server side code to work out the correct post ID (given the URL ist valid).
 
Chromaniac said:
the thing is that # based links are not going to work in all circumstances.
Click to expand...
In which case why are they there? Surely we need a user-friendly intuitive and consistent way to link to posts (apart from quoting). This is all a bit of a mess now that it seems it will stop working the way it used to.
 
Kirby said:
Actually I think it shouldn't be too difficult - just needs a bit server side code to work out the correct post ID (given the URL ist valid).
Click to expand...
So, not exactly relevant to this thread. But I recently updated from 2.2.8 to 2.2.13 and I am noticing a weird behavior with my post links. Clicking on a post permalink takes me to a link like this: URL/?post=1638792#post-1638792 instead of just URL/#post-1638792. This does not seem to be happening here on 2.3 so not sure what's going on.
 
This is what i do most times when i need to chat about a point that has been made.
i hard click on the post link until it comes up with copy link.
i will take a screenshot of the point being made and upload it.

IMG_0093.webp
Here's my modem speed results for example's sake as a screenshot.
As a link i'll link my mate's bigfooty site. https://www.bigfooty.com/forum/threads/last-post.1375900/page-2
if want a direct link i do this.
IMG_0104.webp

See the copy link. I press that

Last Post

www.bigfooty.com www.bigfooty.com
 
Still a bug in the beta release, users are finding it annoying.

But at least I can turn it off so not a total showstopper
 
There is another bug with embeds, not the the same as this one because it is not related to there being an anchor link, ie not related to there being a # in because there isn't.

See:

Mr Lucky

Fixed Thread 'Embedded internal link to resource tab pages not working'

This appears maybe NOT to be the same as this one:

because that one seems to be diagnosed by people as related specifically to anchor links , ie with links with #

This is definitely to do with a link going to a specific page not an anchor, e.g. the reviews page accessed via the tab:

https://xenforo.com/community/resources/how-to-duplicate-a-live-site-to-use-as-a-test-site.2792/reviews

When embedded (see below) it doesn't link as expected to the review page it goes...
 
Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.3.0 Release Candidate 1).

Change log:
Better handling for resolving embeds to content when an achor is present in the URL.
Click to expand...
There may be a delay before changes are rolled out to the XenForo Community.
 
Back
Top Bottom