Not a bug Old conversation phrases re-appearing in RC4

Mr. Jinx

Well-known member
Affected version
XF 2.3 RC4
I updated all outdated and modified phrases in RC3.
After upgrading to RC4, suddenly a lot (about 100) of 'conversation' related phrases re-appeared untranslated.
I checked my old translation file, those phrases were already translated in a previous version.

1718694415835.webp

1718694425757.webp

RC4 example:
Code:
<phrase title="conversation_email_html_footer" addon_id="XF" version_id="2001270" version_string="2.0.12">

Previous version:
Code:
<phrase title="conversation_email_html_footer" addon_id="XF" version_id="2021470" version_string="2.2.14">

So the previous version seems to have a higher version number for the 'problem' phrases.
 
As multiple developers work on the same project, sometimes our metadata gets a little out of sync. I'm not sure if there's been a little bit of confusion caused because we're also multiple developers working on multiple versions of the same project.

But in actual fact, the RC4 download I have does not have any conversation phrases in. Nor should it. We don't use the conversation phrases any more as they are all e.g. direct_message_email_html_footer.

I think the main issue here stems from perhaps your translation having those phrases, or some parent version of the translation having those phrases.

As such, I don't think there's anything we need to do here. Those phrases aren't in our code, aren't in the download, and they shouldn't be in any of the languages. You may need to simply identify where they're coming from and delete them.
 
Ok I respect that, but this makes maintaining a translation very difficult for me.
Apparently, those old phrases are not in your code, but how should I deal with it if they are still in the original translation file and keep come back as untranslated?

As I said before, I updated the translation for RC3. Everything translated, 100% up-to-date.
Then I just upgraded tot RC4 and those deprecated phrases show up again.

I mean, what am I doing wrong or what should I do to prevent this if this it not an error or bug?
 
Last edited:
I just did an upgrade to RC4 on my localhost test server.
I have translated most of the phrases users see to swedish.
I do not see any of the old conversation phrases.

Could it be if you import a language, I have not done that for many years.

I sometimes wonder if there are phrases in there that no longer are used from earlier verions of xf or/anf addons and if there is any way to find them.
This time, for me, the old conversations phrases seems to have been taken out as they should.
 
Back
Top Bottom