• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

Fixed No perm error after add-on installation

R

ragtek

Guest
#1
I'm no superadmin in a board.

I have perm. to install & manage add-ons.
This means=>

I can access the install page, BUT AFTER the installation, i'm getting
You do not have permission to view this page or perform this action.
url: admin.php?add-ons/install

If i go now to "list all add-ons" i can see that the add-on was installed.

So bug is: after installation i'm getting an "no perm" error even i have permissions and the add-on gets installed
 
R

ragtek

Guest
#2
Also, all the phrases are in the xml install file, but they weren't imported => (ok it's because of the missing cache rebuild)
phrs.png

I've searched for them in the phrase search, but didn't find any new phrase:(
 
R

ragtek

Guest
#3
The same is also happening if i try to delete an add-on.

The add-on isn't in the list anymore, BUT no cache rebuild happened (need to check if tables, templates & etc... are gone or still in the db:( )

Steps to reproduce:

Create an user.
Give him ONLY "manage add-ons" admin permission
Try to deinstall a add-on

Try to install a add-on.
 
R

ragtek

Guest
#4
Found the problem
PHP:
class XenForo_ControllerAdmin_Tools extends XenForo_ControllerAdmin_Abstract
{
  public function actionCacheRebuild()
    {
        $this->assertAdminPermission('rebuildCache');
After the add-on in/deinstallation the cache is being rebuilt.
If you have no "rebuildCache" perm => error and broken install:)

Where should i send my bill for bug searching & fixing?:p
 

Mike

XenForo developer
Staff member
#5
I actually already found that code - it needs to be moved, but the rebuild cache framework can't be perm checked like that.