Fixed Merging a user allows self-ignore/self-follow until the ignored/followed is changed.

X

Xon

Well-known member
Affected version
2.0.10
When a user is merged;
  1. Content is reassigned (via ContentChange service) (including follow/ignore lists.)
  2. ContentChange service does a caches rebuild
  3. Merge service then does a post-merge cleanup; records where are user would be ignoring/following themselves are pruned.
This cache will then persist until the ignore/follow lists are modified, and the cache rebuilt.

It would make sense that rebuildFollowingCache/rebuildIgnoredCache enforce this policy of no self-ignore/follow by skipping any records where an ignored/followed user is their self.
 
Last edited:
Thank you for reporting this issue. The issue is now resolved and we are aiming to include that in a future XF release (2.0.12).

Change log:
Ensure that the user following cache cannot include your own user ID.
Click to expand...
Any changes made as a result of this issue being resolved may not be rolled out here until later.
 
Just an additional note on this, no changes have been made to the rebuildIgnoredCache method as this already excludes being able to ignore yourself.
 
Back
Top Bottom