Fixed Is it intended that users in state "email_bounce" can reply to conversations?

[Steffen]

Affected version

2.0.12

Users in state "email_bounce" cannot post to your forums and they cannot start new conversations. But it seems like they can reply to existing conversations. This has caught me by surprise. Is this intended behavior or a bug?

At least in combination with this bug this seems problematic.

--- a/src/XF/Entity/ConversationMaster.php
+++ b/src/XF/Entity/ConversationMaster.php
@@ -64,6 +64,11 @@ class ConversationMaster extends Entity
 
 	public function canReply()
 	{
+		if (\XF::visitor()->user_state != 'valid')
+		{
+			return false;
+		}
+
 		// if a conversation isn't open, we want the creator to know by not showing the reply box
 		return $this->conversation_open;
 	}

 

[XF Bug Bot]

Thank you for reporting this issue. It has now been resolved and we are aiming to include it in a future XF release (2.1.0 B7/RC1).

Change log:

Do not allow users in an invalid state to reply to conversations.

Any changes made as a result of this issue being resolved may not be rolled out here until later.