Duplicate Incorrect generation of class names in \XF\Import\Manager::getImporterShortNamesForType

[Artificial Intelligence]

.example: \XF\Import\Manager::getImporterShortNamesForType('BS\JointPurchases') will give us BS\JointPurchases:EstheticCollaborativeShopping in windows and will get nothing in linux systems. If we write like that \XF\Import\Manager::getImporterShortNamesForType('BS/JointPurchases'), we will get it BS/JointPurchases:EstheticCollaborativeShopping, but it will not work, because BS/JointPurchases\Import\Importer\EstheticCollaborativeShopping class does not exist.

It has to use this method to add importers:

$imps = \XF\Import\Manager::getImporterShortNamesForType('BS/JointPurchases');

$imps = array_map(function($v)
{
    return str_replace('/', '\\', $v);
}, $imps);

$importers = array_merge(
    $importers, $imps
);

 

[Chris D]

I think roughly that code is already in XF 2.0.10.

Which version of XF were you testing with?

Here's the original bug report:

Fixed - Import manager does not handle vendor prefix

We've created an Importers Add-on with a vendor prefix (eg. ID is vendorprefix/id), but this does not seem to be handled correctly in \XF\Import\Manager::getImporterShortNamesForType(), the Importer does not get listed.

xenforo.com

 

[Artificial Intelligence]

.XF 2.0.10 =)

 

[Artificial Intelligence]

.wrong, on XF 2.0.10 I tested the following code: \XF\Import\Manager::getImporterShortNamesForType('BS\JointPurchases').
Well, if it is fixed. Thank you =)

 

[Chris D]

The "type" here is actually the add-on ID, essentially. So it should be:

\XF\Import\Manager::getImporterShortNamesForType('BS/JointPurchases')

For me, that returns:

array(1) {
  [0] => string(36) "BS\JointPurchases:EstheticCollaborativeShopping"
}

I suspect either you're using it wrong or you're using a version older than XF 2.0.10.