How to update this statement to PHP 5.4

[tyteen4a03]

Added this, then added the previous fix but still got NULL.

Are you viewing as yourself, or as a guest? Just wondering.

 

[OakleyForum]

Viewed it as myself.

 

[tyteen4a03]

Meh, might as well set up PHP 5.4 myself.

 

[Jeremy]

Meh, might as well set up PHP 5.4 myself.

In XenTrade_Controller_Public, does $this->hasPermission() usually have a $user? I should probably charge my computer... Lol.

 

[OakleyForum]

Ok, let me know if you need any info from me.

 

[tyteen4a03]

In XenTrade_Controller_Public, does $this->hasPermission() usually have a $user? I should probably charge my computer... Lol.

What is XenTrade_Controller_Public?

Most of the permission check I saw uses a simple XenForo_Visitor::getInstance()->hasPermission(), it's that XenTrader has a complicated permission checking system (did not thoroughly read code) it has to call it instead of a simple hasPermission call like everybody else uses.

 

[Jeremy]

I'm on a phone. Give me a break. XenTrader_ControllerPublic_Index. I feel like I remember most don't have a $user passed. Quick glance I remember being confused on how it worked.

 

[tyteen4a03]

Ok, let me know if you need any info from me.

I don't think I'll be able to look into this issue until tomorrow, so I'll just let KK help you

 

[tyteen4a03]

I'm on a phone. Give me a break. XenTrader_ControllerPublic_Index. I feel like I remember most don't have a $user passed. Quick glance I remember being confused on how it worked.

Just kidding.

Permission checking in XenTrader_ControllerPublic_Index calls _assertHasPermission in XenTrader_ControllerPublic_Abstract
_assertHasPermission in XenTrader_ControllerPublic_Abstract:

    protected function _assertHasPermission($permission = '', $user = null)
    {
        if (!$this->getModelFromCache('XenTrader_Model_Feedback')->hasPermission($permission, $user))
            throw $this->responseException($this->responseNoPermission());
    }

Yes, most of the calls didn't pass in the $user argument.

 

[OakleyForum]

I really need to learn PHP

So any chance you can fix it?

 

[tyteen4a03]

I really need to learn PHP

So any chance you can fix it?

Judging from my knowledge of the code and how I derped a bit (shh, don't let KK know), I'd say wait for KK to charge his laptop up.

 

[OakleyForum]

Haha, Ok sounds good! Thanks for all the help so far!

 

[Jeremy]

Judging from my knowledge of the code and how I derped a bit (shh, don't let KK know), I'd say wait for KK to charge his laptop up.

Too late! I know. I'll charge my laptop in a few minutes. I'm not sure what PHP version I actually have.

 

[OakleyForum]

Did you get a chance to take a look?

 

[Jeremy]

Did you get a chance to take a look?

No. I'll give it a look during lunch.

 

[Akinak]

http://www.php.net/manual/en/migration54.incompatible.php

Call-time pass by reference has been removed.

http://www.php.net/manual/en/language.references.pass.php

public function standardizeViewingUserReference(array &$user = null) - wrong construction in php 5.4

 

[OakleyForum]

Made the change, which resolved the error, but when I go to /XenTrader/Leave-feedback I get an error saying I don't have permission. In addition to the fact that it still doesn't show the XenTrader tab in Navbar, UserProfiles or Under avatars in threads, so viewing a members feedback is very difficult let alone leaving it.

Any ideas?

 

[tyteen4a03]

http://www.php.net/manual/en/migration54.incompatible.php

http://www.php.net/manual/en/language.references.pass.php

public function standardizeViewingUserReference(array &$user = null) - wrong construction in php 5.4

Pretty sure it means $object->doSomeReferencedCall(&$variable), not the other way round.