Fixed Highlighted code not retained in code modal

[mattrogowski]

Affected version

2.2.8

Searched and haven't found reported elsewhere...

If you paste some code into the message body, highlight it and select the "Code" BBCode (the full one not the inline one), it used to retain the code you'd highlighted, however now says "undefined". This seems to have only recently broken.

2.2.6:




2.2.8:




Reproduced locally and on forums here.

It's weird though as doesn't seem to always happen. At first it appeared to only be if the code was > 1 line, but can get it to work with multiple lines sometimes... this code snippet always has the issue tho.

 

[mattrogowski]

I can no longer reproduce this after a browser update - if nobody else is able to reproduce and doesn't get reported again then can probably close.

 

[Xon]

It will be some sort of javascript race condition, the code model stuff is kinda buggy at times.

 

[Chris D]

Was this Firefox? This should be fine in the next release if so.

 

[hdmi]

The issue is back, but this time around the 1st line appears instead of undefined. It happens regardless of whether I use Firefox or Edge.

 

[Chris D]

This does seem to be the case so moving back to bugs.

 

[smozgur]

This does seem to be the case so moving back to bugs.

Confirmed Thread 'Editor - Insert Code takes the first line only'

Aug 13, 2024

If you select a multiline code and use the code button on the editor, only the first line of the selection is copied into the Insert Code popup window. I believe this was fixed in 2.1 or 2.2, but it looks like it is back.
I hoped it was in Safari on Mac only, but also the same behavior in Chrome on Windows.

• smozgur
• Replies: 0
• Forum: Bug reports

• 

 

[Chris D]

Oops. Thanks. I knew it seemed familiar...