• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

Fixed Hidden file hashes present when hidden files aren't

Affected version
XF 2.0.0 Beta 3

Liam W

Well-known member
#1
For some reason, hidden dot-folders (.git, to be precise here) are still being put into the hashes.json file, even though they aren't being included in the zip.

This makes installing an add-on (almost) impossible.

Liam
 
Last edited:

Kier

XenForo Developer
Staff member
#2
I'm struggling to reproduce this - could you provide a listing of the files included and the hashes.json that was generated so i can attempt to get it working myself?
 

Liam W

Well-known member
#3
Sure:

JSON:
{
    "src/addons/LiamW/PostMacros/.git/COMMIT_EDITMSG": "60424313fc202f4d82b95a322af8d52b54e47d9521b46af780e08c2e6acd74ca",
    "src/addons/LiamW/PostMacros/.git/config": "a49c3512ac8155da7b60b801072af0ec2e0cd38128f411f3307caa74949cde19",
    "src/addons/LiamW/PostMacros/.git/description": "85ab6c163d43a17ea9cf7788308bca1466f1b0a8d1cc92e26e9bf63da4062aee",
    "src/addons/LiamW/PostMacros/.git/HEAD": "f6f2b945f6c411b02ba3da9c7ace88dcf71b6af65ba2e0d89aa82900042b5a10",
    "src/addons/LiamW/PostMacros/.git/hooks/applypatch-msg.sample": "0223497a0b8b033aa58a3a521b8629869386cf7ab0e2f101963d328aa62193f7",
    "src/addons/LiamW/PostMacros/.git/hooks/commit-msg.sample": "1f74d5e9292979b573ebd59741d46cb93ff391acdd083d340b94370753d92437",
    "src/addons/LiamW/PostMacros/.git/hooks/post-update.sample": "81765af2daef323061dcbc5e61fc16481cb74b3bac9ad8a174b186523586f6c5",
    "src/addons/LiamW/PostMacros/.git/hooks/pre-applypatch.sample": "e15c5b469ea3e0a695bea6f2c82bcf8e62821074939ddd85b77e0007ff165475",
    "src/addons/LiamW/PostMacros/.git/hooks/pre-commit.sample": "12c723235131f1c5576c652ac2a0a007f261a93c0ddc445b1dcee6cd98e30788",
    "src/addons/LiamW/PostMacros/.git/hooks/pre-push.sample": "4b1119e1e13a212571976f4aee77847cdbd40978546d6273a557e238981a40d1",
    "src/addons/LiamW/PostMacros/.git/hooks/pre-rebase.sample": "d24bb1ec5d4ad70fc1b51bf4c7925795fc9526f53387ba32cc11ca2fd9755a59",
    "src/addons/LiamW/PostMacros/.git/hooks/pre-receive.sample": "a4c3d2b9c7bb3fd8d1441c31bd4ee71a595d66b44fcf49ddb310252320169989",
    "src/addons/LiamW/PostMacros/.git/hooks/prepare-commit-msg.sample": "f7e5627b5a26d0026ef50352f7393350ee58cc101f5e8337f944b57a5039968c",
    "src/addons/LiamW/PostMacros/.git/hooks/update.sample": "751c037320024ec2ee2757f3ffae0b10ad2c946367684e7059d4dc97eac7e431",
    "src/addons/LiamW/PostMacros/.git/index": "fcffbc1d815f2eec8272e6d5a1fd615ca094c9514d359ac6d67f24db22529573",
    "src/addons/LiamW/PostMacros/.git/info/exclude": "6671fe83b7a07c8932ee89164d1f2793b2318058eb8b98dc5c06ee0a5a3b0ec1",
    "src/addons/LiamW/PostMacros/.git/logs/HEAD": "0b2e759e2a1d279a1d18d31351c458e8c64246a27d279d238edbd70161b33684",
    "src/addons/LiamW/PostMacros/.git/logs/refs/heads/master": "0b2e759e2a1d279a1d18d31351c458e8c64246a27d279d238edbd70161b33684",
    "src/addons/LiamW/PostMacros/.git/logs/refs/remotes/origin/master": "5a591a620b4b5dc3b17f8112f7a3ad8326822822d35bff166eff697c57352fc3",
    "src/addons/LiamW/PostMacros/.git/objects/0a/7e79614386687486dca8750dbe520b1ee58412": "c15a8f6295c4d13632f024d9bc999802a2185b4d257f5a937c04ade7fa17d90c",
    "src/addons/LiamW/PostMacros/.git/objects/0a/548edca718360305d91d8bed24c4a203fa40ed": "2085dd80b7075026df1560cdf30b876c3275c978983ea26abd45402f98c8de38",
    "src/addons/LiamW/PostMacros/.git/objects/0a/da10b8501d752a12474c72baa29844edf076e4": "4cec09b251d3d4e1b2562cf733778fc644521d7d4f21c45d4f7a03b779447774",
    "src/addons/LiamW/PostMacros/.git/objects/0b/0ea848cd836f1e4c6ef863bdd8dd5c8b500398": "72109d95c74b858f8cea6edd49fbabd976b57235601e2d8fd21e3a0296d8ff55",
    "src/addons/LiamW/PostMacros/.git/objects/0b/d3889eba13c070e8f10c15b34d7d9b63e3d19d": "b9247b9bca6674965101996701fb05a048d16c73ac5e95129d63de4c6545e8cb",
    "src/addons/LiamW/PostMacros/.git/objects/0b/dc0e34da9a06ea71c50434d3b57ab026a84e95": "678a4ed1dc5126eb51e535de7b0288ff08ed34c048339dbb287c2bca02ae68cc",
    "src/addons/LiamW/PostMacros/.git/objects/0b/f440ed62b42170bccc5011f969b1e971cb2f29": "0d1c33055631b56ed54ac4385cb4755bc91f81ba4fbdcb154a61a29ec1c38ef4",
    "src/addons/LiamW/PostMacros/.git/objects/0c/9b0c0eab6abb42f2395d1cd2bc23912c7ebdbb": "2037db58fc9591212d139b482b5146383efdced3d564f00abcd2ffb5f879fa72",
    "src/addons/LiamW/PostMacros/.git/objects/0c/20eb62f41e2cde7fb6b3511dea27cd8219887f": "4622a8069953d93d54363ac624e51391694d3f01d1d60198abcdc1fa8ab8e018",
    "src/addons/LiamW/PostMacros/.git/objects/0c/360ae4066c66517e5329236c378f44840207a1": "97b260f00fc8bcca47e15d524903796b0e8b2b4657eb43fced3accf92520ffb6",
    "src/addons/LiamW/PostMacros/.git/objects/0d/75224428c20aba71681ea53478cc5339461bf6": "5ad1651d593187775f9b3680bab0da20db1245da92ecc3e1311fca3946042ee9",
    "src/addons/LiamW/PostMacros/.git/objects/0d/c92f9502268cf355ec3038f6cc3328c227a2c5": "7ccafa3bbea09cb89b3725b44d186ab51df973815079da0c40ef4f5092245a9b",
    "src/addons/LiamW/PostMacros/.git/objects/0e/722c5c09038a1bf25d799eb9adf195f2c41610": "d3ba34ff85b2cee76aeb7de9c194dd78b40d0ff6d85e951b894e18a6f7a3dbe6",
    "src/addons/LiamW/PostMacros/.git/objects/0f/0386ea547effffd8a823024d97eaf10698bc07": "7281ccddd62479726c52a43e15d9c35711cc2ab890df7945b0c0b202f60a7690",
    "src/addons/LiamW/PostMacros/.git/objects/0f/6ff8cd54e72f1a218cdaa951973c8bf05d0542": "fb5d6714fe8703e65a0c26edd55b3243fec66d4a670de778586e9613f348979c",
    "src/addons/LiamW/PostMacros/.git/objects/00/d006e328df5befa191b96650e73631ff30cc05": "660daedd888b242077a756f8c18a0deb1665a05ad73db733a26804b11fb49ef9",
    "src/addons/LiamW/PostMacros/.git/objects/01/d00fc9bade96c366d144bc003028c1607c1494": "508b82f3e5820ae37ece522a5e388bd1ee9ceebb6f9728596e31c9f7d1ada927",
    "src/addons/LiamW/PostMacros/.git/objects/02/6c3cdd9bd5ca0f4a5f497a68b2406ed1bb1ced": "509889250ec70851be8fb4076feb6d22eaed4241f09e3625c116c1c6ab17d1f2",
    "src/addons/LiamW/PostMacros/.git/objects/02/e759568a152a518aab5b7b127cc55ec9d81fb0": "02562a2907c8f223213f7781f0756975d5ae8900b8764165c5d5a32548fa12a6",
    "src/addons/LiamW/PostMacros/.git/objects/04/1dd78de93f489ab5206213c26db0da81faba07": "cf1ed0887e713218c108ca2a8bc61194ad82739f1142fddc511a3870f8104336",
    "src/addons/LiamW/PostMacros/.git/objects/04/4329ed424918a47159328d9b017dba165f2e80": "871e622433093231f5edecb75aacf47fbd6d8b1801bd669382cb0a7d995811f2",
    "src/addons/LiamW/PostMacros/.git/objects/06/37a088a01e8ddab3bf3fa98dbe804cbde1a0dc": "d596f56b4ab387e9dcc8c299f625cd656a871455a3295cb5fec80a87be595c4c",
    "src/addons/LiamW/PostMacros/.git/objects/06/f469ee23ae5188f939302f6a1f7d65d2d36a76": "3ae0e9f1ebbedad9ef8b089e3ca3899d41f425b3030f41e367dc72522cee8397",
    "src/addons/LiamW/PostMacros/.git/objects/07/cb8782083e570b98aec6b675d68cb8699f56a8": "ee4dd5c19a8d5c717f21409d2057cbab0618fed2a05e9a7801edc8bf15a4e825",
    "src/addons/LiamW/PostMacros/.git/objects/08/e24d2cca67278377a0f1141d55c8cd9964ef5e": "5b6df19a8c7992318c6048e235bd0f760c2e381103f09efa7dc964408dab8d49",
    "src/addons/LiamW/PostMacros/.git/objects/09/7d94aff83cb693aaf523d4005ff0f07c8cb6d8": "48b014808353926cf1ffbf61fe600a7958bf5a8b8bb79867f97954ca491ad4e5",
    "src/addons/LiamW/PostMacros/.git/objects/09/636f9d352a61646d5844cd6ecaed59d074c03b": "c8e79dca7332fc438136016ffa450c7b4d353418ce6377985247fdc82a1fd834",
    "src/addons/LiamW/PostMacros/.git/objects/1a/4ad03e36685a95f8be7ea61d476c56d9dcf2ee": "60fd2b7c9eb819efd74b217c7cdde73ffea151950bd6790293ed3e8fd0b28cae",
    "src/addons/LiamW/PostMacros/.git/objects/1b/dd706c247f75dbcac3f6f218b6cba7495df6a7": "5268e9caef1c3df21d30e0163801d7bff27dae21b895969287fcd4ba0bcc36fb",
    "src/addons/LiamW/PostMacros/.git/objects/1c/ca673ec7cdbe970a91a9c6a67212ebca81faac": "1467beb22397b099ddde3395e46f53613d0cc4064e10b8a97cacb7ebf85cd161",
    "src/addons/LiamW/PostMacros/.git/objects/1d/b2d08060c6085d82073f71ce4ba212d9deffc7": "ca02e3f9217ee2545464305154e46d85734240d548f86b41c08c3e144bcfc739",
    "src/addons/LiamW/PostMacros/.git/objects/1d/ed68c524b2782dedd0114f0a90fca08762a545": "02899093b97ef9bd11d5722a1f5794119f4d206a8297acba83923e02ada00fbf",
    "src/addons/LiamW/PostMacros/.git/objects/1d/fd60bb055bc3d1c32dbd38e83b7ccd634643e4": "e45a0b138e93eee0332d82731531611a40230c2cd4ab099ff9629d94030590c1",
    "src/addons/LiamW/PostMacros/.git/objects/1e/b6632f2fa7149746a960f6deadfff41e4d8f76": "07824009168846529a8ee71b74a2b656948c6341cadc622ec2abe33d551dd695",
    "src/addons/LiamW/PostMacros/.git/objects/1e/d75bb9d3c220fb55d39a96342b13067ba1cb79": "cd11ac31e098787b4b0b58cebbce1673924ec49542739ac3680e47c3cc4edc0b",
    "src/addons/LiamW/PostMacros/.git/objects/1f/5f0996fe1d6ef348df66d24cb6dede7b7498e0": "ae71ee84c88fc0b8a0028eb373914b507b0cb9a7ab36aaa75e19d4ba0ab908c8",
    "src/addons/LiamW/PostMacros/.git/objects/1f/a363f3718c43d1e79feb02c6c4860f77a84171": "37a9d6674d4be3533a1223c019d650f3b454fb0ac06901f150f4032ce000c87e"
}
There was a lot more, but apparently it was too long to process :(

Going into the directory, no .git directory present.

(The hashes.json file is 76Kb)
 

Kier

XenForo Developer
Staff member
#4
Right - so it's dot folders that are being included rather than files. No problem, I know how to fix that...
 

Kier

XenForo Developer
Staff member
#5
All sorted - I've changed the system so that it no longer copies all files into the _build directory and then selectively zips and hashes - instead it now does all the filtering before it does any copying, so no post-filtering is necessary.