Fixed Guests referred to as "you" in news feed items for guest content

[Jeremy P]

Affected version

2.1.6a

Per title. If a post by a guest (or deleted user) is reacted to, the news feed item will say 'X reacted to your post...'.

 

[djbaxter]

I don't understand. How is this a bug? or why is it a problem?

 

[Jeremy P]

All guests (logged out visitors) are assumed to have created the content.

 

[beerForo]

To clarify, by X do you mean yourself?

 

[Jeremy P]

No.

Let's say I have guest posting enabled (but this can also be reproduced with a deleted account). You make a post as a guest and John Doe likes your post. I visit the forum logged out. The news feed will say 'John Doe liked your post in the thread Y' to me, even though I did not author the post.

The conditional in the template is a simple user ID comparison. If the author user ID matches the visitor user ID, it assumes the content is yours. Normally that makes sense, but all guests have the user ID 0.

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.1.7).

Change log:

Check for guest posts in post reaction items

There may be a delay before changes are rolled out to the XenForo Community.