Not a bug generateAttachmentThumbnail has no contextual information

[Xon]

Affected version

2.0.9

In all call locations, the raw or entity xf_attachment_data record is available, but this information isn't passed in.

This prevents any sort of logic based on the context of the attachment from being used when the thumbnail is built or when the thumbnails are rebuild.

 

[Chris D]

This isn't really a bug on the basis that we don't internally require any additional context for the default use case. For add-on/content type-specific thumbnails, we very much so recommend those are created in addition to the default thumbnail rather than instead of (the aim being that the default thumbnail is sort of a "master" that we can display in an expected and consistent resolution regardless of content type). We take this approach with XFMG thumbnails.

If your aim is to extend/change something related to the master thumbnails then I can understand why additional context might be needed there but you may have to try and roll your own solution for that.

That said, we could consider changes here but they would be 2.1 level changes (at the earliest) so I'd recommend posting a suggestion and provide use cases so we can perhaps work them in going forward.