- Affected version
- 2.3.0
There seem to be some issues with 
	
	
	
		
I've attached the whole Add-on, it's basically just
	
	
	
		
to demonstrate the issue.
I can reproduce this on 2.3.0 and 2.3.2 with PHP 7.2 and 7.3; PHP 7.4+ seems to be fine.
While I luckily don't have to use PHP 7.2 / 7.3 and could probably work around this issue, it would be nice if it could be fixed.
				
			XF::createAliasForClass()
		Code:
	
	ErrorException: [E_WARNING] Declaration of ClassAliasTest\XF\Pub\Controller\Forum::applyForumFilters(XF\Entity\Forum $forum, XF\Finder\Thread $threadFinder, array $filters) should be compatible with XF\Pub\Controller\ForumController::applyForumFilters(XF\Entity\Forum $forum, XF\Finder\ThreadFinder $threadFinder, array $filters)
src/addons/ClassAliasTest/XF/Pub/Controller/Forum.php:0I've attached the whole Add-on, it's basically just
		PHP:
	
	namespace ClassAliasTest\XF\Pub\Controller;
class Forum extends XFCP_Forum
{
    protected function applyForumFilters(\XF\Entity\Forum $forum, \XF\Finder\Thread $threadFinder, array $filters)
    {
        return parent::applyForumFilters($forum, $threadFinder, $filters);
    }
}I can reproduce this on 2.3.0 and 2.3.2 with PHP 7.2 and 7.3; PHP 7.4+ seems to be fine.
While I luckily don't have to use PHP 7.2 / 7.3 and could probably work around this issue, it would be nice if it could be fixed.
Attachments
			
				Last edited: 
			
		
	
								
								
									
	
								
							
							 
 
		 
 
		 
 
		 
 
		 
 
		