XF 2.0 fetching elements from sometimes empty finder results

[Marcus]

I receive "ErrorException: [E_NOTICE] Trying to get property of non-object" when fetchOne() does not return elements. Do I always have to isset() the finders results before fetching the username here?

$finder->where('user_id', 1)->fetchOne()->username;

https://xf2demo.xenforo.com/dev-docs/entities-finders-repositories/

 

[Chris D]

You don't need to use isset, but you do need to actually check whether you have a user object. If your code is focused around having a user then presumably the subsequent code isn't much use.

$user = $finder->where('user_id', 1);
if (!$user)
{
    // throw an exception ? log an error ? return ?
    return;
}
$username = $user->username;