1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Fatal Error: Stack overflow - library/XenForo/Html/Renderer/BbCode.php

Discussion in 'Resolved Bug Reports' started by Zenexer, Feb 26, 2016.

  1. Zenexer

    Zenexer Active Member

    ErrorException: Fatal Error: Stack overflow - library/XenForo/Html/Renderer/BbCode.php:389
    Generated By: *****, Saturday at 7:21 AM

    Stack Trace
    #0 (): XenForo_Application::handleFatalError()
    #1 {main}

    Request State
    https://gist.github.com/Zenexer/26a6810a84020e24d755 (Please respect the member's privacy and don't quote any of the text from this. Our members dislike it when their domain names are posted elsewhere.)

    XenForo 1.4.6 + all security updates

    Shouldn't there be a check in place to prevent a stack overflow from occurring, even with heavily nested HTML/BB code?
    Last edited: Feb 26, 2016
    SAS1024 likes this.
  2. tyteen4a03

    tyteen4a03 Well-Known Member

    (That is some really badly formatted BBCode... o_O)
    pegasus likes this.
  3. Mike

    Mike XenForo Developer Staff Member

    Stack overflows are very variable based on environmental conditions. You can likely change it on your system (ulimit -s). It's worth pointing out that this didn't trigger any issues on my initial test (in Windows).

    That said, I have made changes to effectively limit HTML tags parsed to a depth a 100, which should be more than enough for all legitimate cases. Text beyond that limit will still be maintained.
    Zenexer likes this.

Share This Page