Duplicate False Method used in XenForo_DataWriter_NewsFeed

[ragtek]

The getExistinData method doesn't work.

    protected function _getExistingData($data)
    {
        if (!$newsFeedId = $this->_getExistingPrimaryKey($data))
        {
            return false;
        }

        return array('xf_news_feed' => $this->_getNewsFeedModel()->getNewsFeedById($newsFeedId));
    }

should be

    protected function _getExistingData($data)
    {
        if (!$newsFeedId = $this->_getExistingPrimaryKey($data))
        {
            return false;
        }

        return array('xf_news_feed' => $this->_getNewsFeedModel()->getNewsFeedItemById($newsFeedId));
    }

xfrocks found this and it should be fixed ( http://xenforo.com/community/thread...o_datawriter_newsfeed-_getexistingdata.15880/ ) but it isn't in 1.0.4

 

[PhpMember]

Good catch

 

[Mike]

http://xenforo.com/community/threads/bug-in-xenforo_datawriter_newsfeed-_getexistingdata.18672/