Fixed ErrorException during email sending

[Mike Fara]

In the original code there is this statement:

                        // Any error may put us in an inconsistent state, so we need to reset the connection.
                        // Ideally this shouldn't throw anything but it could happen so we just want to swall>
                        // all errors and continue on.
                        try
                        {
                                $transport->stop();
                        }
                        catch (\Throwable $null) {}
                }

Was this added after you posted your fix? The only reason I ask is because its very similar to your "finally { }" statement. I don't know, but I'm getting the same error and presumably this is why I've heard rumors there will be a different mailer software in 2.3. I am not confident with how to apply your fix in the latest XenForo version because of the code I've encountered above (presumably does the same thing)? Otherwise, the issue persists. Seems to happen if the mail server (in this case GSuite/Google Workspaces) thinks its being DDOS'd or something and throws a Try again later error. Then its just like broken pipe 300 times.

 

[Externalizable]

In the original code there is this statement:

                        // Any error may put us in an inconsistent state, so we need to reset the connection.
                        // Ideally this shouldn't throw anything but it could happen so we just want to swall>
                        // all errors and continue on.
                        try
                        {
                                $transport->stop();
                        }
                        catch (\Throwable $null) {}
                }

Was this added after you posted your fix? The only reason I ask is because its very similar to your "finally { }" statement. I don't know, but I'm getting the same error and presumably this is why I've heard rumors there will be a different mailer software in 2.3. I am not confident with how to apply your fix in the latest XenForo version because of the code I've encountered above (presumably does the same thing)? Otherwise, the issue persists. Seems to happen if the mail server (in this case GSuite/Google Workspaces) thinks its being DDOS'd or something and throws a Try again later error. Then its just like broken pipe 300 times.

Yes, that code snippet was added in XenForo 2.2.5 after I opened this bug report. The code added by the XenForo team does address the issue my site was facing and we haven't had issues since, but it's possible that you and others participating in this thread might be facing unrelated mailing issues that need to be addressed separately.