Fixed Error in ControllerAdmin/AdminTemplate.php at line 285

[Arty]

I've made a error when editing admin template: tried to put spinbox inside radiounit. But instead of showing error message, XenForo threw ErrorException:

A non-numeric value encountered
    XenForo_Application::handlePhpError() in XenForo/ControllerAdmin/AdminTemplate.php at line 285
    XenForo_ControllerAdmin_AdminTemplate->actionSaveMultiple() in XenForo/FrontController.php at line 351
    XenForo_FrontController->dispatch() in XenForo/FrontController.php at line 134
    XenForo_FrontController->run() in admin.php at line 13

Line that triggered error is third line of this code in XenForo_ControllerAdmin_AdminTemplate::actionSaveMultiple:

				foreach ($errors AS $i => $error)
				{
					$errorText .= "\n" . ($i + 1) . ")\t$error";
				}

Dump of $errors array:

Array
(
    [template] => user_group_edit_avatar_dimensions - Line 7: Found unexpected tag 'spinboxunit' as a disabled control.
)

XenForo 1.5.10a, PHP 7.1.0RC2

 

[Mike]

This is fixed now, thanks. The whole list numbering didn't work (and multiple errors should be quite rare).